code review 231042: Generate same output on all architectures.

Generate same output on all architectures.

Passing an argument to bug260 will indicate which alignments
are wrong.

[iant, 2010-03-05 18:37:16]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-03-05 18:39:45]

LGTM

i will abandon mine

On Mar 5, 2010, at 10:37 AM, iant@golang.org wrote:

> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> Generate same output on all architectures.
>
> Passing an argument to bug260 will indicate which alignments
> are wrong.
>
> Please review this at http://codereview.appspot.com/231042/show
>
> Affected files:
>  M test/bugs/bug260.go
>  M test/golden.out
>
>
> Index: test/bugs/bug260.go
> ===================================================================
> --- a/test/bugs/bug260.go
> +++ b/test/bugs/bug260.go
> @@ -1,4 +1,4 @@
> -// $G $D/$F.go && $L $F.$A && ./$A.out
> +// $G $D/$F.go && $L $F.$A && ./$A.out || echo BUG: bug260 failed
>
> // Test that structures pack densely, according to the alignment of  
> the largest field.
>
> @@ -15,27 +15,41 @@
> type T4 struct { x uint32 }
>
> func main() {
> +	report := len(os.Args) > 1
> 	status := 0
> 	var b1 [10]T1
> 	a0, _ := strconv.Btoui64(fmt.Sprintf("%p", &b1[0])[2:], 16)
> 	a1, _ := strconv.Btoui64(fmt.Sprintf("%p", &b1[1])[2:], 16)
> 	if a1 != a0 + 1 {
> -		fmt.Println("FAIL: alignment should be 1, is", a1-a0)
> +		fmt.Println("FAIL")
> +		if report {
> +			fmt.Println("alignment should be 1, is", a1-a0)
> +		}
> 		status = 1
> 	}
> 	var b2 [10]T2
> 	a0, _ = strconv.Btoui64(fmt.Sprintf("%p", &b2[0])[2:], 16)
> 	a1, _ = strconv.Btoui64(fmt.Sprintf("%p", &b2[1])[2:], 16)
> 	if a1 != a0 + 2 {
> -		fmt.Println("FAIL: alignment should be 2, is", a1-a0)
> -		status = 1
> +		if status == 0 {
> +			fmt.Println("FAIL")
> +			status = 1
> +		}
> +		if report {
> +			fmt.Println("alignment should be 2, is", a1-a0)
> +		}
> 	}
> 	var b4 [10]T4
> 	a0, _ = strconv.Btoui64(fmt.Sprintf("%p", &b4[0])[2:], 16)
> 	a1, _ = strconv.Btoui64(fmt.Sprintf("%p", &b4[1])[2:], 16)
> 	if a1 != a0 + 4 {
> -		fmt.Println("FAIL: alignment should be 4, is", a1-a0)
> -		status = 1
> +		if status == 0 {
> +			fmt.Println("FAIL")
> +			status = 1
> +		}
> +		if report {
> +			fmt.Println("alignment should be 4, is", a1-a0)
> +		}
> 	}
> 	os.Exit(status)
> }
> Index: test/golden.out
> ===================================================================
> --- a/test/golden.out
> +++ b/test/golden.out
> @@ -152,6 +152,5 @@
> == bugs/
>
> =========== bugs/bug260.go
> -FAIL: alignment should be 1, is 8
> -FAIL: alignment should be 2, is 8
> -FAIL: alignment should be 4, is 8
> +FAIL
> +BUG: bug260 failed
>
>

[iant, 2010-03-05 18:43:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=54093ab72578 ***

Generate same output on all architectures.

Passing an argument to bug260 will indicate which alignments
are wrong.

R=r
CC=golang-dev
http://codereview.appspot.com/231042