Issue 2310041: code review 2310041: Effective Go: update for new http interface.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2310041: code review 2310041: Effective Go: update for new http interface. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by r

Modified:
14 years, 5 months ago

Reviewers:

CC:
rsc, stephenm, golang-dev

Visibility:
Public.

Description

Effective Go: update for new http interface.

Patch Set 2 : code review 2310041: Effective Go: update for new http interface. #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -15 lines)			Patch
	M	doc/effective_go.html	View	1	7 chunks	+24 lines, -15 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc, stephenm (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2010-09-29 17:59:45 UTC) #1

rsc1

LGTM http://codereview.appspot.com/2310041/diff/1/doc/effective_go.html File doc/effective_go.html (right): http://codereview.appspot.com/2310041/diff/1/doc/effective_go.html#newcode1881 doc/effective_go.html:1881: func (ctr *Counter) ServeHTTP(c http.ResponseWriter, req *http.Request) { ...

14 years, 5 months ago (2010-09-29 18:02:58 UTC) #2

14 years, 5 months ago (2010-09-29 18:12:55 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=3101675f717f ***

Effective Go: update for new http interface.

R=rsc, stephenm
CC=golang-dev
http://codereview.appspot.com/2310041

Expand All Messages | Collapse All Messages