code review 2302041: doc: update http handler usage for new signature

doc: update http handler usage for new signature

[stephenm, 2010-09-29 08:46:19]

Hello adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-09-29 20:01:16]

On Sep 29, 2010, at 1:46 AM, stephenm@golang.org wrote:

> Reviewers: adg,
> 
> Message:
> Hello adg (cc: golang-dev@googlegroups.com),
> 
> I'd like you to review this change.
> 
> 
> Description:
> doc: update http handler usage for new signature
> 
> Please review this at http://codereview.appspot.com/2302041/
> 
> Affected files:
>  M doc/codelab/wiki/final-noclosure.go
>  M doc/codelab/wiki/final-noerror.go
>  M doc/codelab/wiki/final-parsetemplate.go
>  M doc/codelab/wiki/final-template.go
>  M doc/codelab/wiki/final.go
>  M doc/codelab/wiki/http-sample.go
>  M doc/codelab/wiki/index.html
>  M doc/codelab/wiki/notemplate.go
>  M doc/codelab/wiki/part2.go
>  M doc/codelab/wiki/wiki.html
>  M doc/effective_go.html
> 
> 

i did the effective_go part. you can revert that file.

-rob

[adg, 2010-09-29 23:40:14]

LGTM

Do all the .go files compile?
Did you regenerate index.html with 'make' ?

On 29 September 2010 18:46,  <stephenm@golang.org> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> doc: update http handler usage for new signature
>
> Please review this at http://codereview.appspot.com/2302041/
>
> Affected files:
>  M doc/codelab/wiki/final-noclosure.go
>  M doc/codelab/wiki/final-noerror.go
>  M doc/codelab/wiki/final-parsetemplate.go
>  M doc/codelab/wiki/final-template.go
>  M doc/codelab/wiki/final.go
>  M doc/codelab/wiki/http-sample.go
>  M doc/codelab/wiki/index.html
>  M doc/codelab/wiki/notemplate.go
>  M doc/codelab/wiki/part2.go
>  M doc/codelab/wiki/wiki.html
>  M doc/effective_go.html
>
>
>

[stephenm, 2010-09-30 03:13:49]

> i did the effective_go part. you can revert that file.

ok. thanks.

- S

[stephenm, 2010-09-30 03:14:14]

On 2010/09/29 23:40:14, adg wrote:
> LGTM
> 
> Do all the .go files compile?
> Did you regenerate index.html with 'make' ?

Yes and yes.

Thanks.

- S

[stephenm, 2010-09-30 03:21:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=60b050d102f0 ***

doc: update http handler usage for new signature

R=adg, r2
CC=golang-dev
http://codereview.appspot.com/2302041