Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(734)

Issue 230045: spectrum framework

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by Nicola Baldo
Modified:
10 years, 3 months ago
Reviewers:
Gary Pei
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 14

Patch Set 2 : revised code 2010-05-21 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9497 lines, -2 lines) Patch
A examples/spectrum/adhoc-ofdm-aloha.cc View 1 1 chunk +198 lines, -0 lines 0 comments Download
A examples/spectrum/adhoc-ofdm-aloha-with-microwave-oven.cc View 1 chunk +266 lines, -0 lines 0 comments Download
A examples/spectrum/waf View 1 chunk +1 line, -0 lines 0 comments Download
A examples/spectrum/wscript View 1 1 chunk +12 lines, -0 lines 0 comments Download
A src/common/friis-spectrum-propagation-loss.h View 1 chunk +78 lines, -0 lines 0 comments Download
A src/common/friis-spectrum-propagation-loss.cc View 1 chunk +108 lines, -0 lines 1 comment Download
A src/common/spectrum-converter.h View 1 chunk +91 lines, -0 lines 0 comments Download
A src/common/spectrum-converter.cc View 1 chunk +107 lines, -0 lines 0 comments Download
A src/common/spectrum-model.h View 1 1 chunk +114 lines, -0 lines 0 comments Download
A src/common/spectrum-model.cc View 1 chunk +108 lines, -0 lines 0 comments Download
A src/common/spectrum-propagation-loss-model.h View 1 chunk +103 lines, -0 lines 0 comments Download
A src/common/spectrum-propagation-loss-model.cc View 1 chunk +71 lines, -0 lines 0 comments Download
A src/common/spectrum-type.h View 1 chunk +80 lines, -0 lines 0 comments Download
A src/common/spectrum-type.cc View 1 chunk +95 lines, -0 lines 0 comments Download
A src/common/spectrum-value.h View 1 1 chunk +525 lines, -0 lines 0 comments Download
A src/common/spectrum-value.cc View 1 chunk +670 lines, -0 lines 0 comments Download
A src/common/spectrum-value-test.cc View 1 1 chunk +370 lines, -0 lines 0 comments Download
M src/common/wscript View 1 2 chunks +13 lines, -0 lines 0 comments Download
M src/core/ptr.h View 1 chunk +14 lines, -0 lines 0 comments Download
A src/devices/spectrum/aloha-noack-mac-header.h View 1 chunk +55 lines, -0 lines 0 comments Download
A src/devices/spectrum/aloha-noack-mac-header.cc View 1 chunk +108 lines, -0 lines 0 comments Download
A src/devices/spectrum/aloha-noack-net-device.h View 1 chunk +227 lines, -0 lines 0 comments Download
A src/devices/spectrum/aloha-noack-net-device.cc View 1 chunk +487 lines, -0 lines 0 comments Download
A src/devices/spectrum/half-duplex-ideal-ofdm-phy.h View 1 1 chunk +233 lines, -0 lines 0 comments Download
A src/devices/spectrum/half-duplex-ideal-ofdm-phy.cc View 1 1 chunk +410 lines, -0 lines 0 comments Download
A src/devices/spectrum/microwave-oven-spectrum-value-helper.h View 1 chunk +67 lines, -0 lines 0 comments Download
A src/devices/spectrum/microwave-oven-spectrum-value-helper.cc View 1 chunk +165 lines, -0 lines 0 comments Download
A src/devices/spectrum/multi-model-spectrum-channel.h View 1 1 chunk +185 lines, -0 lines 0 comments Download
A src/devices/spectrum/multi-model-spectrum-channel.cc View 1 1 chunk +336 lines, -0 lines 0 comments Download
A src/devices/spectrum/non-communicating-net-device.h View 1 chunk +137 lines, -0 lines 0 comments Download
A src/devices/spectrum/non-communicating-net-device.cc View 1 chunk +262 lines, -0 lines 0 comments Download
A src/devices/spectrum/single-model-spectrum-channel.h View 1 1 chunk +109 lines, -0 lines 0 comments Download
A src/devices/spectrum/single-model-spectrum-channel.cc View 1 1 chunk +203 lines, -0 lines 0 comments Download
A src/devices/spectrum/spectrum-analyzer.h View 1 1 chunk +118 lines, -0 lines 0 comments Download
A src/devices/spectrum/spectrum-analyzer.cc View 1 1 chunk +226 lines, -0 lines 0 comments Download
A src/devices/spectrum/spectrum-error-model.h View 1 chunk +94 lines, -0 lines 0 comments Download
A src/devices/spectrum/spectrum-error-model.cc View 1 chunk +72 lines, -0 lines 0 comments Download
A src/devices/spectrum/spectrum-interference.h View 1 chunk +137 lines, -0 lines 0 comments Download
A src/devices/spectrum/spectrum-interference.cc View 1 1 chunk +135 lines, -0 lines 0 comments Download
A src/devices/spectrum/spectrum-interference-test.cc View 1 chunk +235 lines, -0 lines 0 comments Download
A src/devices/spectrum/spectrum-model-300kHz-300GHz-log.h View 1 chunk +38 lines, -0 lines 0 comments Download
A src/devices/spectrum/spectrum-model-300kHz-300GHz-log.cc View 1 chunk +51 lines, -0 lines 0 comments Download
A src/devices/spectrum/spectrum-model-ism2400MHz-res1MHz.h View 1 chunk +39 lines, -0 lines 0 comments Download
A src/devices/spectrum/spectrum-model-ism2400MHz-res1MHz.cc View 1 chunk +53 lines, -0 lines 0 comments Download
A src/devices/spectrum/waveform-generator.h View 1 1 chunk +165 lines, -0 lines 0 comments Download
A src/devices/spectrum/waveform-generator.cc View 1 1 chunk +218 lines, -0 lines 0 comments Download
A src/devices/spectrum/wifi-spectrum-value-helper.h View 1 chunk +95 lines, -0 lines 0 comments Download
A src/devices/spectrum/wifi-spectrum-value-helper.cc View 1 chunk +110 lines, -0 lines 0 comments Download
A src/devices/spectrum/wscript View 1 1 chunk +43 lines, -0 lines 0 comments Download
A src/helper/adhoc-aloha-noack-ideal-ofdm-helper.h View 1 chunk +124 lines, -0 lines 0 comments Download
A src/helper/adhoc-aloha-noack-ideal-ofdm-helper.cc View 1 1 chunk +156 lines, -0 lines 0 comments Download
A src/helper/spectrum-analyzer-helper.h View 1 chunk +120 lines, -0 lines 0 comments Download
A src/helper/spectrum-analyzer-helper.cc View 1 chunk +198 lines, -0 lines 0 comments Download
A src/helper/spectrum-helper.h View 1 chunk +224 lines, -0 lines 0 comments Download
A src/helper/spectrum-helper.cc View 1 chunk +202 lines, -0 lines 0 comments Download
A src/helper/waveform-generator-helper.h View 1 chunk +113 lines, -0 lines 0 comments Download
A src/helper/waveform-generator-helper.cc View 1 chunk +133 lines, -0 lines 0 comments Download
M src/helper/wscript View 1 5 chunks +9 lines, -1 line 0 comments Download
A src/node/phy-mac.h View 1 1 chunk +73 lines, -0 lines 0 comments Download
A src/node/spectrum-channel.h View 1 1 chunk +105 lines, -0 lines 0 comments Download
A src/node/spectrum-channel.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A src/node/spectrum-phy.h View 1 1 chunk +117 lines, -0 lines 0 comments Download
A src/node/spectrum-phy.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M src/node/wscript View 2 chunks +5 lines, -0 lines 0 comments Download
M src/wscript View 1 1 chunk +2 lines, -1 line 0 comments Download
M test.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Gary Pei
Hi, Sorry for late reply. I just got chance to take a look at this ...
11 years, 2 months ago (2010-04-02 21:25:25 UTC) #1
Nicola Baldo
Hi Gary, thank you for your review, and sorry for the very late reply. Below ...
11 years, 1 month ago (2010-05-21 15:08:43 UTC) #2
Gary Pei
10 years, 3 months ago (2011-02-28 23:44:44 UTC) #3
I believe it should be Pr = Pt / (4 PI d / lamda) ^2.

http://codereview.appspot.com/230045/diff/10001/src/common/friis-spectrum-pro...
File src/common/friis-spectrum-propagation-loss.cc (right):

http://codereview.appspot.com/230045/diff/10001/src/common/friis-spectrum-pro...
src/common/friis-spectrum-propagation-loss.cc:89: double loss = ( d * f * f) /
((3e8 * 3e8) / (4 * M_PI)) ;
This does not seem to be correct.

How about replacing the this line to the following:
double loss = ( d * f) / (3e8 / (4 * M_PI)) ; 
loss *= loss;
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b