Issue 2297041: code review 2297041: gotest: leave _testmain.go for "make clean" to clean up

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2297041: code review 2297041: gotest: leave _testmain.go for "make clean" to clean up (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by rsc

Modified:
14 years, 5 months ago

Reviewers:

CC:
r, brainman, golang-dev

Visibility:
Public.

Description

gotest: leave _testmain.go for "make clean" to clean up

Patch Set 2 : code review 2297041: gotest: leave _testmain.go for "make clean" to clean up #

Total comments: 2

Patch Set 3 : code review 2297041: gotest: leave _testmain.go for "make clean" to clean up #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/cmd/gotest/gotest	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2010-09-29 01:42:05 UTC) #1

brainman

not LGTM http://codereview.appspot.com/2297041/diff/2001/src/Make.pkg File src/Make.pkg (right): http://codereview.appspot.com/2297041/diff/2001/src/Make.pkg#newcode53 src/Make.pkg:53: CLEANFILES+=*.cgo1.go *.cgo2.c _cgo_defun.c _cgo_gotypes.go _cgo_export.* *.so _obj ...

14 years, 5 months ago (2010-09-29 02:50:15 UTC) #3

rsc1

http://codereview.appspot.com/2297041/diff/2001/src/Make.pkg File src/Make.pkg (right): http://codereview.appspot.com/2297041/diff/2001/src/Make.pkg#newcode53 src/Make.pkg:53: CLEANFILES+=*.cgo1.go *.cgo2.c _cgo_defun.c _cgo_gotypes.go _cgo_export.* *.so _obj _test _testmain.go ...

14 years, 5 months ago (2010-09-29 02:58:37 UTC) #4

rsc

14 years, 5 months ago (2010-09-29 02:59:19 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=fad8b087570d ***

gotest: leave _testmain.go for "make clean" to clean up

R=r, brainman
CC=golang-dev
http://codereview.appspot.com/2297041

Expand All Messages | Collapse All Messages