Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(452)

Issue 2294041: code review 2294041: runtime: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 5 months ago by rsc
Modified:
14 years, 5 months ago
Reviewers:
r2
CC:
r, golang-dev
Visibility:
Public.

Description

runtime: fix build On systems where the mmap succeeds (e.g., sysctl -w vm.mmap_min_addr=0) it changes the signal code delivered for a nil fault from ``page not mapped'' to ``invalid permissions for page.''

Patch Set 1 #

Patch Set 2 : code review 2294041: runtime: fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/pkg/runtime/darwin/thread.c View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/freebsd/thread.c View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/linux/thread.c View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 5 months ago (2010-09-29 00:49:59 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=1e0172bf33c8 *** runtime: fix build On systems where the mmap succeeds (e.g., ...
14 years, 5 months ago (2010-09-29 00:50:02 UTC) #2
r2
14 years, 5 months ago (2010-09-29 00:55:52 UTC) #3
LGTM

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b