Issue 229046: code review 229046: gc: fix imported and not used message - show path

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 229046: code review 229046: gc: fix imported and not used message - show path (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
15 years ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

gc: fix imported and not used message - show path

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -4 lines)			Patch
M	src/cmd/gc/lex.c	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/gc/subr.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/walk.c	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	test/import4.go	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-04 01:23:46 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=394a4cafb55a *** gc: fix imported and not used message - show path ...

15 years ago (2010-03-04 01:23:54 UTC) #2

LGTM