Issue 2290045: code review 2290045: build: disable archive/zip for nacl (fix build)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2290045: code review 2290045: build: disable archive/zip for nacl (fix build) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by rsc

Modified:
14 years, 5 months ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

build: disable archive/zip for nacl (fix build)

Patch Set 1 #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/pkg/Makefile	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2010-10-06 15:25:33 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=8836a39b169e *** build: disable archive/zip for nacl (fix build) TBR=adg CC=golang-dev http://codereview.appspot.com/2290045

14 years, 5 months ago (2010-10-06 15:25:53 UTC) #2

adg

14 years, 5 months ago (2010-10-07 00:23:39 UTC) #3

LGTM

On 7 October 2010 02:25,  <rsc@golang.org> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=8836a39b169e ***
>
> build: disable archive/zip for nacl (fix build)
>
> TBR=adg
> CC=golang-dev
> http://codereview.appspot.com/2290045
>
>
> http://codereview.appspot.com/2290045/
>

Expand All Messages | Collapse All Messages