Issue 2290041: code review 2290041: libcgo: don't build for NaCl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2290041: code review 2290041: libcgo: don't build for NaCl (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by rsc

Modified:
14 years, 5 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

libcgo: don't build for NaCl

Patch Set 1 #

Patch Set 2 : code review 2290041: libcgo: don't build for NaCl #

Patch Set 3 : code review 2290041: libcgo: don't build for NaCl #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	src/libcgo/Makefile	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello nigeltao (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2010-09-28 19:40:52 UTC) #1

rsc

14 years, 5 months ago (2010-09-29 01:53:10 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e5a37de55b4f ***

libcgo: don't build for NaCl

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/2290041

Expand All Messages | Collapse All Messages