Issue 2288041: code review 2288041: 6l, 8l: elfsetstring is only for .shstrtab

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2288041: code review 2288041: 6l, 8l: elfsetstring is only for .shstrtab (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by rsc

Modified:
14 years, 5 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

6l, 8l: elfsetstring is only for .shstrtab Was also recording for .dynstrtab which made the table run out of space and would have caused confusion if the ELF code tried to refer to any of the strings.

Patch Set 1 #

Patch Set 2 : code review 2288041: 6l, 8l: elfsetstring is only for .shstrtab #

Patch Set 3 : code review 2288041: 6l, 8l: elfsetstring is only for .shstrtab #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/cmd/6l/asm.c	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/cmd/8l/asm.c	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2010-09-28 17:51:12 UTC) #1

rsc

14 years, 5 months ago (2010-09-28 19:18:06 UTC) #3

*** Submitted as 153360f9c7e9 ***

6l, 8l: elfsetstring is only for .shstrtab

Was also recording for .dynstrtab which made the
table run out of space and would have caused confusion
if the ELF code tried to refer to any of the strings.

R=r
CC=golang-dev
http://codereview.appspot.com/2288041

Expand All Messages | Collapse All Messages