[benchmark] Add Fetch API performance tests.

[benchmark] Add Fetch API performance tests.

- Introduces initWorker() and doAction(), and move common code to util.js.
- Changes verifyBlob's doneCallback arguments to match with fetch()'s promises.
- Adds 'Access-Control-Allow-Origin: *' header to XHR/fetch responses because cross-origin fetch() without such headers is not allowed even with --disable-web-security.

R=tyoshino@chromium.org

Committed: https://code.google.com/p/pywebsocket/source/detail?r=862

[hiroshige, 2015-04-09 07:32:47]

PTAL.
This is for adding Fetch()/XHR benchmarks to the performance bots.

[hiroshige, 2015-04-23 11:16:52]

ping.

[tyoshino (chromium.org), 2015-04-24 04:03:22]

On 2015/04/23 11:16:52, hiroshige wrote:
> ping.

Sorry. I'm reviewing this now. Please feel free to ping if you don't get any
response from me in e.g. two days.

[tyoshino (chromium.org), 2015-04-24 07:18:43]

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
File src/example/fetch_benchmark.html (right):

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.html:21: numXHRs: getIntFromInput('numXHRs'),
numFetches

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.html:32: // minTotal is not yet implemented on XHR
benchmark
Fetch API benchmark

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
File src/example/fetch_benchmark.js (right):

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:38: }
can we factor out this into util.js?

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:74: if (response.status != 200) {
+4 space indent for L73 and +2 space indent for L74

If you referred to some style guide that recommends this indentation, please
just let me know.

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:85: if (!verifyAcknowledgement(config, text,
size)) {
ditto

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:97: if (benchmark.startTimeInMs == null) {
ditto

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:106: config.addToLog("ERROR: " + e);
ditto

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:117: t0 = performance.now();
remove

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:153: return new Promise(function(resolve,reject)
{
space after ,

https://codereview.appspot.com/226870043/diff/100001/src/example/util.js
File src/example/util.js (right):

https://codereview.appspot.com/226870043/diff/100001/src/example/util.js#newc...
src/example/util.js:276: if (message.data.type === 'addToLog')
two space indent as it's not wrapping by () but function definition.

https://codereview.appspot.com/226870043/diff/100001/src/example/util.js#newc...
src/example/util.js:292: else {
put in the same line

https://codereview.appspot.com/226870043/diff/100001/src/example/xhr_benchmar...
File src/example/xhr_benchmark.js (right):

https://codereview.appspot.com/226870043/diff/100001/src/example/xhr_benchmar...
src/example/xhr_benchmark.js:155: var verificationResult =
bytesReceivedAndVerificationResult[1];
is this prep for merging fetch and XHR code?

[hiroshige, 2015-07-29 08:41:56]

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
File src/example/fetch_benchmark.html (right):

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.html:21: numXHRs: getIntFromInput('numXHRs'),
On 2015/04/24 07:18:42, tyoshino (chromium.org) wrote:
> numFetches

Done.

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.html:32: // minTotal is not yet implemented on XHR
benchmark
On 2015/04/24 07:18:42, tyoshino (chromium.org) wrote:
> Fetch API benchmark

Done.

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
File src/example/fetch_benchmark.js (right):

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:38: }
On 2015/04/24 07:18:42, tyoshino (chromium.org) wrote:
> can we factor out this into util.js?

Done.

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:74: if (response.status != 200) {
On 2015/04/24 07:18:42, tyoshino (chromium.org) wrote:
> +4 space indent for L73 and +2 space indent for L74
> 
> If you referred to some style guide that recommends this indentation, please
> just let me know.

My indentation here is based on Service Worker's Layout Tests Style
https://www.chromium.org/blink/serviceworker/testing.

I changed the indentation around .then and .catch in Patch Set 10 (i.e. Google
JavaScript Style).

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:85: if (!verifyAcknowledgement(config, text,
size)) {
On 2015/04/24 07:18:43, tyoshino (chromium.org) wrote:
> ditto

Done.

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:97: if (benchmark.startTimeInMs == null) {
On 2015/04/24 07:18:42, tyoshino (chromium.org) wrote:
> ditto

Done.

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:106: config.addToLog("ERROR: " + e);
On 2015/04/24 07:18:43, tyoshino (chromium.org) wrote:
> ditto

Done.

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:117: t0 = performance.now();
On 2015/04/24 07:18:43, tyoshino (chromium.org) wrote:
> remove

Done.

https://codereview.appspot.com/226870043/diff/100001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:153: return new Promise(function(resolve,reject)
{
On 2015/04/24 07:18:43, tyoshino (chromium.org) wrote:
> space after ,

Done.

https://codereview.appspot.com/226870043/diff/100001/src/example/util.js
File src/example/util.js (right):

https://codereview.appspot.com/226870043/diff/100001/src/example/util.js#newc...
src/example/util.js:276: if (message.data.type === 'addToLog')
On 2015/04/24 07:18:43, tyoshino (chromium.org) wrote:
> two space indent as it's not wrapping by () but function definition.

Done.

https://codereview.appspot.com/226870043/diff/100001/src/example/util.js#newc...
src/example/util.js:292: else {
On 2015/04/24 07:18:43, tyoshino (chromium.org) wrote:
> put in the same line

Done.

https://codereview.appspot.com/226870043/diff/100001/src/example/xhr_benchmar...
File src/example/xhr_benchmark.js (right):

https://codereview.appspot.com/226870043/diff/100001/src/example/xhr_benchmar...
src/example/xhr_benchmark.js:155: var verificationResult =
bytesReceivedAndVerificationResult[1];
On 2015/04/24 07:18:43, tyoshino (chromium.org) wrote:
> is this prep for merging fetch and XHR code?

Yes, this was due to a verifyBlob() change to share it with fetch_benchmark.js.
But I reverted the changes here and around verifyBlob (in Patch Set 9) to the
change set smaller.

[hiroshige, 2015-08-18 04:25:57]

ping. I want to complete the review before pywebsocket migration which will
start this week.

[tyoshino (chromium.org), 2015-08-19 09:09:52]

lgtm!

https://codereview.appspot.com/226870043/diff/280001/src/example/fetch_benchm...
File src/example/fetch_benchmark.html (right):

https://codereview.appspot.com/226870043/diff/280001/src/example/fetch_benchm...
src/example/fetch_benchmark.html:22: async: getBoolFromCheckBox('async'),
unnecessary for fetch?

https://codereview.appspot.com/226870043/diff/280001/src/example/fetch_benchm...
src/example/fetch_benchmark.html:99: (Receive && Non-Worker &&
Sync is not supported by spec)
these 3 lines unnecessary for fetch?

https://codereview.appspot.com/226870043/diff/280001/src/example/fetch_benchm...
File src/example/fetch_benchmark.js (right):

https://codereview.appspot.com/226870043/diff/280001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:176: size * config.numFetches, isWarmUp);
indentation

[hiroshige, 2015-08-19 09:55:04]

Thank you for reviewing!

https://codereview.appspot.com/226870043/diff/280001/src/example/fetch_benchm...
File src/example/fetch_benchmark.html (right):

https://codereview.appspot.com/226870043/diff/280001/src/example/fetch_benchm...
src/example/fetch_benchmark.html:22: async: getBoolFromCheckBox('async'),
On 2015/08/19 09:09:51, tyoshino (chromium.org) wrote:
> unnecessary for fetch?

Done.

https://codereview.appspot.com/226870043/diff/280001/src/example/fetch_benchm...
src/example/fetch_benchmark.html:99: (Receive && Non-Worker &&
Sync is not supported by spec)
On 2015/08/19 09:09:51, tyoshino (chromium.org) wrote:
> these 3 lines unnecessary for fetch?

Done.

https://codereview.appspot.com/226870043/diff/280001/src/example/fetch_benchm...
File src/example/fetch_benchmark.js (right):

https://codereview.appspot.com/226870043/diff/280001/src/example/fetch_benchm...
src/example/fetch_benchmark.js:176: size * config.numFetches, isWarmUp);
On 2015/08/19 09:09:51, tyoshino (chromium.org) wrote:
> indentation

Done.

[hiroshige, 2015-08-19 09:57:13]

Committed patchset #12 (id:300001) manually as r862 (presubmit successful).