Issue 226510043: setup: Fix deprecated APIs since GTK 3.12 (Closed)
Descriptionsetup: Fix deprecated APIs since GTK 3.14
GtkAlignment and GtkMisc have been no longer available since GTK 3.14
and use gtk_widget_set_margin_*().
gtk_widget_set_margin_[start|end]() are new in GTK 3.12 so still use
gtk_widget_set_margin_[left|right]()
TEST=setup
Patch Set 1 #Patch Set 2 : Fixed a typo. #Patch Set 3 : Updated minimum. #MessagesTotal messages: 15
On 2015/04/21 08:32:49, fujiwara wrote: why not just update configure.ac to make sure gtk version >= 3.12?
Sign in to reply to this message.
On 2015/04/21 15:40:42, Peng wrote: > On 2015/04/21 08:32:49, fujiwara wrote: > > why not just update configure.ac to make sure gtk version >= 3.12? 3.12 is still too latest. Also some deprecation requires 3.14.
Sign in to reply to this message.
On 2015/04/22 02:10:21, fujiwara wrote: > On 2015/04/21 15:40:42, Peng wrote: > > On 2015/04/21 08:32:49, fujiwara wrote: > > > > why not just update configure.ac to make sure gtk version >= 3.12? > > 3.12 is still too latest. > Also some deprecation requires 3.14. In that case, I suggest just waiting several months, and then replacing those deprecation APIs with new APIs.
Sign in to reply to this message.
On 2015/04/22 15:14:29, Peng wrote: > On 2015/04/22 02:10:21, fujiwara wrote: > > On 2015/04/21 15:40:42, Peng wrote: > > > On 2015/04/21 08:32:49, fujiwara wrote: > > > > > > why not just update configure.ac to make sure gtk version >= 3.12? > > > > 3.12 is still too latest. > > Also some deprecation requires 3.14. > > In that case, I suggest just waiting several months, and then replacing those > deprecation APIs with new APIs. Currently I don't think several to be able to replace APIs but some years. Why do you suggest to break the compatibility? setup has already implemented compatibility of Gtk.ListBox and Gtk.ComboBox. vala has implemented several compatible codes.
Sign in to reply to this message.
On 2015/04/23 02:10:12, fujiwara wrote: > On 2015/04/22 15:14:29, Peng wrote: > > On 2015/04/22 02:10:21, fujiwara wrote: > > > On 2015/04/21 15:40:42, Peng wrote: > > > > On 2015/04/21 08:32:49, fujiwara wrote: > > > > > > > > why not just update configure.ac to make sure gtk version >= 3.12? > > > > > > 3.12 is still too latest. > > > Also some deprecation requires 3.14. > > > > In that case, I suggest just waiting several months, and then replacing those > > deprecation APIs with new APIs. > > Currently I don't think several to be able to replace APIs but some years. Currently I don't think several months to be able to replace APIs but some years. > Why do you suggest to break the compatibility? > setup has already implemented compatibility of Gtk.ListBox and Gtk.ComboBox. > vala has implemented several compatible codes.
Sign in to reply to this message.
On 2015/04/23 02:10:12, fujiwara wrote: > On 2015/04/22 15:14:29, Peng wrote: > > On 2015/04/22 02:10:21, fujiwara wrote: > > > On 2015/04/21 15:40:42, Peng wrote: > > > > On 2015/04/21 08:32:49, fujiwara wrote: > > > > > > > > why not just update configure.ac to make sure gtk version >= 3.12? > > > > > > 3.12 is still too latest. > > > Also some deprecation requires 3.14. > > > > In that case, I suggest just waiting several months, and then replacing those > > deprecation APIs with new APIs. > > Currently I don't think several to be able to replace APIs but some years. > Why do you suggest to break the compatibility? > setup has already implemented compatibility of Gtk.ListBox and Gtk.ComboBox. > vala has implemented several compatible codes. I thnink the new GTK version should still support deprecated api until GTK 4, right? So we should keep using old api and change to new api when we don't want to support old GTK. I think it is not necesary to use different api for different GTK version.
Sign in to reply to this message.
On 2015/04/23 02:28:06, Peng wrote: > On 2015/04/23 02:10:12, fujiwara wrote: > > On 2015/04/22 15:14:29, Peng wrote: > > > On 2015/04/22 02:10:21, fujiwara wrote: > > > > On 2015/04/21 15:40:42, Peng wrote: > > > > > On 2015/04/21 08:32:49, fujiwara wrote: > > > > > > > > > > why not just update configure.ac to make sure gtk version >= 3.12? > > > > > > > > 3.12 is still too latest. > > > > Also some deprecation requires 3.14. > > > > > > In that case, I suggest just waiting several months, and then replacing > those > > > deprecation APIs with new APIs. > > > > Currently I don't think several to be able to replace APIs but some years. > > Why do you suggest to break the compatibility? > > setup has already implemented compatibility of Gtk.ListBox and Gtk.ComboBox. > > vala has implemented several compatible codes. > > I thnink the new GTK version should still support deprecated api until GTK 4, > right? > > So we should keep using old api and change to new api when we don't want to > support old GTK. I think it is not necesary to use different api for different > GTK version. Yes, the deprecated APIs still works but there are warning with setup. % ibus-setup /usr/lib64/python3.4/site-packages/gi/overrides/__init__.py:175: Warning: The property GSettings:schema is deprecated and shouldn't be used anymore. It will be removed in a future version. return super_init_func(self, **new_kwargs) /usr/share/ibus/setup/main.py:102: Warning: The property GtkAlignment:top-padding is deprecated and shouldn't be used anymore. It will be removed in a future version. self.__builder.add_from_file(gtk_builder_file); /usr/share/ibus/setup/main.py:102: Warning: The property GtkAlignment:bottom-padding is deprecated and shouldn't be used anymore. It will be removed in a future version. self.__builder.add_from_file(gtk_builder_file); /usr/share/ibus/setup/main.py:102: Warning: The property GtkAlignment:left-padding is deprecated and shouldn't be used anymore. It will be removed in a future version. self.__builder.add_from_file(gtk_builder_file); /usr/share/ibus/setup/main.py:102: Warning: The property GtkAlignment:right-padding is deprecated and shouldn't be used anymore. It will be removed in a future version. self.__builder.add_from_file(gtk_builder_file); /usr/share/ibus/setup/main.py:102: Warning: The property GtkButton:xalign is deprecated and shouldn't be used anymore. It will be removed in a future version. self.__builder.add_from_file(gtk_builder_file); I've annoyed the warnings from Fedora 20 and it was hard for me to find another bug http://code.google.com/p/ibus/issues/detail?id=1771 It seems the warnings are output for beta versions only and may be disabled in the stable versions. So you're right but some users filed bugs.
Sign in to reply to this message.
On 2015/04/23 02:39:43, fujiwara wrote: > On 2015/04/23 02:28:06, Peng wrote: > > On 2015/04/23 02:10:12, fujiwara wrote: > > > On 2015/04/22 15:14:29, Peng wrote: > > > > On 2015/04/22 02:10:21, fujiwara wrote: > > > > > On 2015/04/21 15:40:42, Peng wrote: > > > > > > On 2015/04/21 08:32:49, fujiwara wrote: > > > > > > > > > > > > why not just update configure.ac to make sure gtk version >= 3.12? > > > > > > > > > > 3.12 is still too latest. > > > > > Also some deprecation requires 3.14. > > > > > > > > In that case, I suggest just waiting several months, and then replacing > > those > > > > deprecation APIs with new APIs. > > > > > > Currently I don't think several to be able to replace APIs but some years. > > > Why do you suggest to break the compatibility? > > > setup has already implemented compatibility of Gtk.ListBox and Gtk.ComboBox. > > > vala has implemented several compatible codes. > > > > I thnink the new GTK version should still support deprecated api until GTK 4, > > right? > > > > So we should keep using old api and change to new api when we don't want to > > support old GTK. I think it is not necesary to use different api for different > > GTK version. > > Yes, the deprecated APIs still works but there are warning with setup. > > % ibus-setup > /usr/lib64/python3.4/site-packages/gi/overrides/__init__.py:175: Warning: The > property GSettings:schema is deprecated and shouldn't be used anymore. It will > be removed in a future version. > return super_init_func(self, **new_kwargs) > /usr/share/ibus/setup/main.py:102: Warning: The property > GtkAlignment:top-padding is deprecated and shouldn't be used anymore. It will be > removed in a future version. > self.__builder.add_from_file(gtk_builder_file); > /usr/share/ibus/setup/main.py:102: Warning: The property > GtkAlignment:bottom-padding is deprecated and shouldn't be used anymore. It will > be removed in a future version. > self.__builder.add_from_file(gtk_builder_file); > /usr/share/ibus/setup/main.py:102: Warning: The property > GtkAlignment:left-padding is deprecated and shouldn't be used anymore. It will > be removed in a future version. > self.__builder.add_from_file(gtk_builder_file); > /usr/share/ibus/setup/main.py:102: Warning: The property > GtkAlignment:right-padding is deprecated and shouldn't be used anymore. It will > be removed in a future version. > self.__builder.add_from_file(gtk_builder_file); > /usr/share/ibus/setup/main.py:102: Warning: The property GtkButton:xalign is > deprecated and shouldn't be used anymore. It will be removed in a future > version. > self.__builder.add_from_file(gtk_builder_file); > > I've annoyed the warnings from Fedora 20 and it was hard for me to find another > bug http://code.google.com/p/ibus/issues/detail?id=1771 > It seems the warnings are output for beta versions only and may be disabled in > the stable versions. > So you're right but some users filed bugs. I see. The warnings are annoying. You may consider using grep to filter them out. I also suggest removing deprecated API regularly. For example, we remove deprecated API which the gtk version is 1 or two years old. I think we shoul
Sign in to reply to this message.
On 2015/04/23 19:31:38, Peng wrote: > On 2015/04/23 02:39:43, fujiwara wrote: > > On 2015/04/23 02:28:06, Peng wrote: > > > On 2015/04/23 02:10:12, fujiwara wrote: > > > > On 2015/04/22 15:14:29, Peng wrote: > > > > > On 2015/04/22 02:10:21, fujiwara wrote: > > > > > > On 2015/04/21 15:40:42, Peng wrote: > > > > > > > On 2015/04/21 08:32:49, fujiwara wrote: > > > > > > > > > > > > > > why not just update configure.ac to make sure gtk version >= 3.12? > > > > > > > > > > > > 3.12 is still too latest. > > > > > > Also some deprecation requires 3.14. > > > > > > > > > > In that case, I suggest just waiting several months, and then replacing > > > those > > > > > deprecation APIs with new APIs. > > > > > > > > Currently I don't think several to be able to replace APIs but some years. > > > > Why do you suggest to break the compatibility? > > > > setup has already implemented compatibility of Gtk.ListBox and > Gtk.ComboBox. > > > > vala has implemented several compatible codes. > > > > > > I thnink the new GTK version should still support deprecated api until GTK > 4, > > > right? > > > > > > So we should keep using old api and change to new api when we don't want to > > > support old GTK. I think it is not necesary to use different api for > different > > > GTK version. > > > > Yes, the deprecated APIs still works but there are warning with setup. > > > > % ibus-setup > > /usr/lib64/python3.4/site-packages/gi/overrides/__init__.py:175: Warning: The > > property GSettings:schema is deprecated and shouldn't be used anymore. It will > > be removed in a future version. > > return super_init_func(self, **new_kwargs) > > /usr/share/ibus/setup/main.py:102: Warning: The property > > GtkAlignment:top-padding is deprecated and shouldn't be used anymore. It will > be > > removed in a future version. > > self.__builder.add_from_file(gtk_builder_file); > > /usr/share/ibus/setup/main.py:102: Warning: The property > > GtkAlignment:bottom-padding is deprecated and shouldn't be used anymore. It > will > > be removed in a future version. > > self.__builder.add_from_file(gtk_builder_file); > > /usr/share/ibus/setup/main.py:102: Warning: The property > > GtkAlignment:left-padding is deprecated and shouldn't be used anymore. It will > > be removed in a future version. > > self.__builder.add_from_file(gtk_builder_file); > > /usr/share/ibus/setup/main.py:102: Warning: The property > > GtkAlignment:right-padding is deprecated and shouldn't be used anymore. It > will > > be removed in a future version. > > self.__builder.add_from_file(gtk_builder_file); > > /usr/share/ibus/setup/main.py:102: Warning: The property GtkButton:xalign is > > deprecated and shouldn't be used anymore. It will be removed in a future > > version. > > self.__builder.add_from_file(gtk_builder_file); > > > > I've annoyed the warnings from Fedora 20 and it was hard for me to find > another > > bug http://code.google.com/p/ibus/issues/detail?id=1771 > > It seems the warnings are output for beta versions only and may be disabled in > > the stable versions. > > So you're right but some users filed bugs. > > I see. The warnings are annoying. You may consider using grep to filter them > out. > I also suggest removing deprecated API regularly. For example, we remove > deprecated API > which the gtk version is 1 or two years old. > > I think we shoul I'm thinking the ABI compatibility especially in gtk3 and glib and probably I think you mean 1 or two years to update ibus 1.5 to 1.6. I guess you mind to rename setup.ui? How about leaving only setup.ui with margin_left and margin_right? And other python codes keep to have if-else likes this patch. Then I can do sed for setup.ui to replace margin_[left|right] with margin_[start|end] during Fedora builds easily. Or do you mind to maintain both the deprecated APIs and new APIs in the codes?
Sign in to reply to this message.
> I'm thinking the ABI compatibility especially in gtk3 and glib and probably I > think you mean 1 or two years to update ibus 1.5 to 1.6. > I guess you mind to rename setup.ui? > How about leaving only setup.ui with margin_left and margin_right? > And other python codes keep to have if-else likes this patch. > Then I can do sed for setup.ui to replace margin_[left|right] with > margin_[start|end] during Fedora builds easily. > > Or do you mind to maintain both the deprecated APIs and new APIs in the codes? I don't like those change. They are difficult to understand and maintain, and the only benefit is less warning messages. :(
Sign in to reply to this message.
On 2015/04/23 02:11:18, fujiwara wrote: > On 2015/04/23 02:10:12, fujiwara wrote: > > On 2015/04/22 15:14:29, Peng wrote: > > > On 2015/04/22 02:10:21, fujiwara wrote: > > > > On 2015/04/21 15:40:42, Peng wrote: > > > > > On 2015/04/21 08:32:49, fujiwara wrote: > > > > > > > > > > why not just update configure.ac to make sure gtk version >= 3.12? > > > > > > > > 3.12 is still too latest. > > > > Also some deprecation requires 3.14. > > > > > > In that case, I suggest just waiting several months, and then replacing > those > > > deprecation APIs with new APIs. > > > > Currently I don't think several to be able to replace APIs but some years. > > Currently I don't think several months to be able to replace APIs but some > years. > > > Why do you suggest to break the compatibility? > > setup has already implemented compatibility of Gtk.ListBox and Gtk.ComboBox. > > vala has implemented several compatible codes. BTW, does it break the compatibility? It only updates required gtk & glib versions.
Sign in to reply to this message.
On 2015/04/24 19:22:07, Peng wrote: > On 2015/04/23 02:11:18, fujiwara wrote: > > On 2015/04/23 02:10:12, fujiwara wrote: > > > On 2015/04/22 15:14:29, Peng wrote: > > > > On 2015/04/22 02:10:21, fujiwara wrote: > > > > > On 2015/04/21 15:40:42, Peng wrote: > > > > > > On 2015/04/21 08:32:49, fujiwara wrote: > > > > > > > > > > > > why not just update configure.ac to make sure gtk version >= 3.12? > > > > > > > > > > 3.12 is still too latest. > > > > > Also some deprecation requires 3.14. > > > > > > > > In that case, I suggest just waiting several months, and then replacing > > those > > > > deprecation APIs with new APIs. > > > > > > Currently I don't think several to be able to replace APIs but some years. > > > > Currently I don't think several months to be able to replace APIs but some > > years. > > > > > Why do you suggest to break the compatibility? > > > setup has already implemented compatibility of Gtk.ListBox and Gtk.ComboBox. > > > vala has implemented several compatible codes. > > BTW, does it break the compatibility? It only updates required gtk & glib > versions. Actually I don't know if ABI can be kept when the supported versions are changed without updating libibus.so version. Most distro uses the latest gtk and glib but some users would use the latest ibus in their old distro. I mind this a little since many application depends on glib and gtk.
Sign in to reply to this message.
|
