strings: Contains

strings: Contains

Tiny helper to avoid strings.Index(s, sub) != -1

[brad_danga_com, 2010-10-22 19:28:31]

Should I drop this?

I think it makes code more readable, though, with less boiler-plate.

[r2, 2010-10-22 20:13:35]

It's simple but I agree it's more readable.  I could accept it.

Please obey r's rule of testing and add tests for the null string cases.

-rob

[brad_danga_com, 2010-11-01 14:31:42]

PTAL

Added tests with the empty string.

[r2, 2010-11-01 17:51:53]

So far so good.  Now comes the annoying part.  It would be good to include, best
here but also ok as a second CL, updates to the tree to use this routine.  One
way to keep things clear is to make sure the code uses the library as it should.
 Updates to the library should affect the code that uses it.  Or to put it
another way, if Contains is better, existing code should be updated to use it.
If it's not, it shouldn't exist.

-rob

[rsc, 2010-11-01 17:56:51]

gofmt -l -r 'strings.Index(a, b) >= 0 -> strings.Contains(a, b)' $GOROOT/src/pkg

(and also != -1) will show candidate files.  changing -l to -w
will rewrite them.

russ

[brad_danga_com, 2010-11-01 19:25:46]

gofmt continues to impress me.

PTAL.

[r2, 2010-11-01 19:53:05]

looking good. what about the !Contains case?

-rob

[brad_danga_com, 2010-11-01 21:12:20]

PTAL

Looks like there was only one case of !Contains, in http/transfer.go:

http://codereview.appspot.com/2265044/patch/14001/15006

[r2, 2010-11-01 21:14:20]

LGTM

[r2, 2010-11-01 21:15:29]

Looks like you need to sync and resolve

tubenose=% hg clpatch 2265044
edit src/pkg/http/server.go: patch did not apply cleanly
hgpatch failed
tubenose=% 

[brad_danga_com, 2010-11-01 21:23:35]

PTAL

did an hg sync and ./all.bash.

[r2, 2010-11-01 21:32:30]

the cmd directory could use the same surgery, but let's do that in a separate
round.

-rob

[r, 2010-11-01 21:32:52]

*** Submitted as http://code.google.com/p/go/source/detail?r=42d67a1ac6fb ***

strings: Contains

Tiny helper to avoid strings.Index(s, sub) != -1

R=rsc, r2, r
CC=golang-dev
http://codereview.appspot.com/2265044

Committer: Rob Pike <r@golang.org>