Issue 2263042: Fix initialization code to resolve API_URI against container

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2263042: Fix initialization code to resolve API_URI against container (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by mhermanto

Modified:
15 years, 3 months ago

Reviewers:
zhoresh, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

While at it, reduced 2 instantiation calls to shindig.uri to one.

Patch Set 1 #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -12 lines)			Patch
		features/src/main/javascript/features/container/init.js	View		1 chunk	+9 lines, -12 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

zhoresh

lgtm Basically window.location is an object and you need to use the href field of ...

15 years, 4 months ago (2010-09-24 18:33:53 UTC) #2

mhermanto

15 years, 4 months ago (2010-09-24 18:34:47 UTC) #3

On Fri, Sep 24, 2010 at 11:33 AM, <zhoresh@gmail.com> wrote:

> lgtm
>
> Basically window.location is an object and you need to use the href
> field of it. And to optimize the call you reuse the __CONTAINER_URI
> value.
>
> Well said. :)

>
>
>
> http://codereview.appspot.com/2263042/
>

Expand All Messages | Collapse All Messages