Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(199)

Issue 2261042: http: Support HTTP/1.0 Keep-Alive (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 5 months ago by brad_danga_com
Modified:
14 years, 4 months ago
Reviewers:
CC:
rsc, bradfitzgoog, golang-dev
Visibility:
Public.

Description

http: Support HTTP/1.0 Keep-Alive

Patch Set 1 #

Patch Set 2 : code review 2261042: http: Support HTTP/1.0 Keep-Alive #

Total comments: 2

Patch Set 3 : code review 2261042: http: Support HTTP/1.0 Keep-Alive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -14 lines) Patch
M src/pkg/http/request.go View 1 chunk +11 lines, -0 lines 0 comments Download
M src/pkg/http/server.go View 1 2 5 chunks +36 lines, -13 lines 0 comments Download
M src/pkg/http/transfer.go View 1 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 3
rsc1
LGTM but please fix the broken comment http://codereview.appspot.com/2261042/diff/2001/src/pkg/http/server.go File src/pkg/http/server.go (right): http://codereview.appspot.com/2261042/diff/2001/src/pkg/http/server.go#newcode59 src/pkg/http/server.go:59: closeAfterReply bool ...
14 years, 5 months ago (2010-09-23 18:31:22 UTC) #1
bradfitzgoog
Ah whoops, didn't double-check the code after gofmt -w. PTAL. On Thu, Sep 23, 2010 ...
14 years, 5 months ago (2010-09-26 16:09:10 UTC) #2
rsc
14 years, 5 months ago (2010-09-28 01:55:05 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=a58b5d046294 ***

http: support HTTP/1.0 Keep-Alive

R=rsc, bradfitz1
CC=golang-dev
http://codereview.appspot.com/2261042

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b