Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 2247042: Set translation on create for issue1694 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by ced
Modified:
15 years, 4 months ago
Reviewers:
yangoon1
Visibility:
Public.

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M trytond/ir/ir.xml View 1 chunk +13 lines, -0 lines 2 comments Download
M trytond/ir/lang.xml View 1 chunk +3 lines, -8 lines 0 comments Download
M trytond/model/modelsql.py View 1 chunk +6 lines, -0 lines 4 comments Download

Messages

Total messages: 6
ced
15 years, 4 months ago (2010-09-19 21:42:29 UTC) #1
yangoon1
Works for me. http://codereview.appspot.com/2247042/diff/1/trytond/ir/ir.xml File trytond/ir/ir.xml (right): http://codereview.appspot.com/2247042/diff/1/trytond/ir/ir.xml#newcode10 trytond/ir/ir.xml:10: <record model="ir.lang" id="lang_en"> If we were ...
15 years, 4 months ago (2010-09-20 09:30:58 UTC) #2
ced
http://codereview.appspot.com/2247042/diff/1/trytond/ir/ir.xml File trytond/ir/ir.xml (right): http://codereview.appspot.com/2247042/diff/1/trytond/ir/ir.xml#newcode10 trytond/ir/ir.xml:10: <record model="ir.lang" id="lang_en"> On 2010/09/20 09:30:59, yangoon wrote: > ...
15 years, 4 months ago (2010-09-20 18:06:28 UTC) #3
yangoon1
http://codereview.appspot.com/2247042/diff/1/trytond/model/modelsql.py File trytond/model/modelsql.py (right): http://codereview.appspot.com/2247042/diff/1/trytond/model/modelsql.py#newcode37 trytond/model/modelsql.py:37: 'Model _table %s cannot end with "__history"' % self._table ...
15 years, 4 months ago (2010-09-21 10:40:08 UTC) #4
ced
http://codereview.appspot.com/2247042/diff/1/trytond/model/modelsql.py File trytond/model/modelsql.py (right): http://codereview.appspot.com/2247042/diff/1/trytond/model/modelsql.py#newcode37 trytond/model/modelsql.py:37: 'Model _table %s cannot end with "__history"' % self._table ...
15 years, 4 months ago (2010-09-21 11:35:34 UTC) #5
yangoon1
15 years, 4 months ago (2010-09-21 14:49:21 UTC) #6
On 2010/09/21 11:35:34, ced wrote:
> http://codereview.appspot.com/2247042/diff/1/trytond/model/modelsql.py
> File trytond/model/modelsql.py (right):
> 
>
http://codereview.appspot.com/2247042/diff/1/trytond/model/modelsql.py#newcode37
> trytond/model/modelsql.py:37: 'Model _table %s cannot end with "__history"' %
> self._table
> On 2010/09/21 10:40:08, yangoon wrote:
> > On 2010/09/20 18:06:28, ced wrote:
> > > On 2010/09/20 09:30:59, yangoon wrote:
> > > > Not for this issue, but just looking at it:
> > > > Shouldn't this be 'Model table %s cannot end with "__history"
> > > 
> > > It is the name of the parameter.
> > > 
> > 
> > User doesn't know parameter. But he can know what is a table.
> 
> It is not raised to users but only devs.

Is someone just using the framework for module development a user or a
developer?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b