Issue 224490043: Fix a reference to a non-existent module.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 224490043: Fix a reference to a non-existent module. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by erikchen1

Modified:
10 years, 3 months ago

Reviewers:
nednguyen

Base URL:
git@github.com:chromium/web-page-replay@master

Visibility:
Public.

More Reviews

Description

Fix a reference to a non-existent module. platformsettings.HasSniSupport() attempted to reference a non-existent module version. Instead, it should be referencing distutils.version. BUG= R=nednguyen@google.com Committed: 4e4d540a18c099e2ad805696072f95815f313c0e

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	platformsettings.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	platformsettings_test.py	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

erikchen1

10 years, 3 months ago (2015-04-15 19:36:17 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4e4d540a18c099e2ad805696072f95815f313c0e (presubmit successful).

Expand All Messages | Collapse All Messages