Issue 2244042: DefaultHtmlSerializer#serialize() should encode entities in attribute nodes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2244042: DefaultHtmlSerializer#serialize() should encode entities in attribute nodes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by chirag

Modified:
14 years, 10 months ago

Reviewers:
Paul Lindner, felix8a, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Currently DefaultHtmlSerializer#serialize() will run attribute values through printAttributeValue() which contains an incomplete list of entities. This change will use Escaping.escapeXml() instead, which escapes all html entities. http://code.google.com/p/google-caja/source/browse/trunk/src/com/google/caja/lexer/escaping/Escaping.java#200

Patch Set 1 #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+57 lines, -19 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/DefaultHtmlSerializer.java	View	2 chunks	+2 lines, -16 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/DefaultHtmlSerializerTest.java	View	2 chunks	+53 lines, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ContentTypeCharsetRemoverRewriterTest.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages