can you check the cssmin in third_party/WebKit and see how its readme.chromium is set up? ...
10 years, 4 months ago
(2015-04-08 04:05:28 UTC)
#2
can you check the cssmin in third_party/WebKit and see how its readme.chromium
is set up? Presumably they've done something to avoid this... lgtm in case this
is the way to do it, but I seem to recall there might be another easy way --- I
just can't remember how.
On 2015/04/08 04:05:28, nduca wrote: > can you check the cssmin in third_party/WebKit and see ...
10 years, 4 months ago
(2015-04-08 04:52:41 UTC)
#3
On 2015/04/08 04:05:28, nduca wrote:
> can you check the cssmin in third_party/WebKit and see how its readme.chromium
> is set up? Presumably they've done something to avoid this... lgtm in case
this
> is the way to do it, but I seem to recall there might be another easy way ---
I
> just can't remember how.
third_party/WebKit only rjsmin.py and that files already has the license
properly.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
On 2015/04/08 04:57:15, nduca wrote: > if we do make changes, we should update the ...
10 years, 4 months ago
(2015-04-08 16:41:47 UTC)
#6
On 2015/04/08 04:57:15, nduca wrote:
> if we do make changes, we should update the readme.chromium files to say what
> local modifications we make.
>
> lets just remove bench.sh
I already "git cl land" this. Will remove those files & add readme.chromium in
the next patch.
Issue 224260043: Add licensing info for rcssmin & rjsmin files
(Closed)
Created 10 years, 4 months ago by nednguyen
Modified 10 years, 4 months ago
Reviewers: nduca
Base URL: https://github.com/google/trace-viewer.git@master
Comments: 0