Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 224260043: Add licensing info for rcssmin & rjsmin files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by nednguyen
Modified:
10 years, 4 months ago
Reviewers:
nduca
CC:
trace-viewer-review_googlegroups.com
Base URL:
https://github.com/google/trace-viewer.git@master
Visibility:
Public.

Description

Add licensing info for rcssmin & rjsmin files This is a workaround for licensing problem in https://codereview.chromium.org/1066903002/

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M third_party/tvcm/third_party/rcssmin/bench.sh View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/tvcm/third_party/rcssmin/bench/cssmin.py View 1 chunk +22 lines, -1 line 0 comments Download
M third_party/tvcm/third_party/rjsmin/bench.sh View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6
nednguyen
10 years, 4 months ago (2015-04-08 02:24:49 UTC) #1
nduca
can you check the cssmin in third_party/WebKit and see how its readme.chromium is set up? ...
10 years, 4 months ago (2015-04-08 04:05:28 UTC) #2
nednguyen
On 2015/04/08 04:05:28, nduca wrote: > can you check the cssmin in third_party/WebKit and see ...
10 years, 4 months ago (2015-04-08 04:52:41 UTC) #3
nduca
hmm https://github.com/ndparker/rcssmin seems to have it?
10 years, 4 months ago (2015-04-08 04:56:43 UTC) #4
nduca
if we do make changes, we should update the readme.chromium files to say what local ...
10 years, 4 months ago (2015-04-08 04:57:15 UTC) #5
nednguyen
10 years, 4 months ago (2015-04-08 16:41:47 UTC) #6
On 2015/04/08 04:57:15, nduca wrote:
> if we do make changes, we should update the readme.chromium files to say what
> local modifications we make.
> 
> lets just remove bench.sh

I already "git cl land" this. Will remove those files & add readme.chromium in
the next patch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b