Issue 2242041: Improve BeanDelegator to use correct sub field type

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2242041: Improve BeanDelegator to use correct sub field type

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by zhoresh

Modified:
15 years, 4 months ago

Reviewers:
dev-remailer, jtarrio

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

This change clean and improve a bit the delegator to use the bean field type in conversion instead of relying on provided list of conversions. This change is needed to simplify overriding of the delegator

Patch Set 1 #

Total comments: 2

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -26 lines)			Patch
		java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java	View		5 chunks	+48 lines, -25 lines	2 comments	Download
		java/common/src/test/java/org/apache/shindig/protocol/conversion/BeanDelegatorTest.java	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jtarrio

lgtm, but small typo http://codereview.appspot.com/2242041/diff/1/java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java File java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java (right): http://codereview.appspot.com/2242041/diff/1/java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java#newcode214 java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java:214: private Class<?> getParamtizedReturnType(Method method) { ...

15 years, 4 months ago (2010-09-17 22:36:49 UTC) #2

zhoresh

15 years, 4 months ago (2010-09-18 00:48:06 UTC) #3

I fixed the function name and committed to r998378

http://codereview.appspot.com/2242041/diff/1/java/common/src/main/java/org/ap...
File
java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java
(right):

http://codereview.appspot.com/2242041/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanDelegator.java:214:
private Class<?> getParamtizedReturnType(Method method) {
On 2010/09/17 22:36:50, jtarrio wrote:
> Parameterized

Done,

Expand All Messages | Collapse All Messages