Issue 224105: code review 224105: more on type complex.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 224105: code review 224105: more on type complex. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by ken3

Modified:
15 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : code review 224105: more on type complex. #

Patch Set 3 : code review 224105: more on type complex. #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+442 lines, -10 lines)			Patch
M	src/cmd/6g/cgen.c	View		4 chunks	+10 lines, -7 lines	0 comments	Download
M	src/cmd/6g/cplx.c	View		4 chunks	+119 lines, -3 lines	0 comments	Download
M	src/cmd/6g/gg.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/6g/gsubr.c	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/cmd/gc/gen.c	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/reflect/type.go	View		2 chunks	+21 lines, -0 lines	0 comments	Download
M	src/pkg/reflect/value.go	View	1 2	2 chunks	+63 lines, -0 lines	0 comments	Download
M	test/golden.out	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A	test/ken/cplx0.go	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download
A	test/ken/cplx1.go	View	1 2	1 chunk	+85 lines, -0 lines	0 comments	Download
A	test/ken/cplx2.go	View	1 2	1 chunk	+95 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ken3

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-03 02:32:09 UTC) #1

ken3

*** Submitted as http://code.google.com/p/go/source/detail?r=f46ba7b160e7 *** more on type complex. getting close. R=rsc CC=golang-dev http://codereview.appspot.com/224105

15 years ago (2010-03-03 02:32:16 UTC) #2

LGTM

Expand All Messages | Collapse All Messages