Issue 224099: Remove HTMLContentRewriter - instead use equivalent replacements

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 224099: Remove HTMLContentRewriter - instead use equivalent replacements (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 10 months ago by johnfargo

Modified:
15 years, 10 months ago

Reviewers:
zhoresh, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

(Finally) kills HTMLContentRewriter in favor of the composition of 3 rewriters run serially: * StyleTagContentRewriter * ScriptTagContentRewriter * ContentReferenceContentRewriter

Patch Set 1 #

Patch Set 2 : Synced to head. #

Created: 15 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -524 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ContentRewriterUris.java	View	1	1 chunk	+0 lines, -63 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/HTMLContentRewriter.java	View	1	1 chunk	+0 lines, -313 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/LinkRewriter.java	View	1	1 chunk	+0 lines, -30 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewriteModule.java	View	1	4 chunks	+19 lines, -6 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/BaseRewriterTestCase.java	View	1	4 chunks	+2 lines, -67 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/DefaultContentRewriterRegistryTest.java	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/HTMLContentRewriterTest.java	View	1	2 chunks	+6 lines, -44 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

zhoresh

LGTM Note that couple of the files you kill here are also killed by CL/248042

15 years, 10 months ago (2010-03-07 19:25:03 UTC) #3

johnfargo

15 years, 10 months ago (2010-03-08 17:04:44 UTC) #4

Thanks Ziv -- and yep, this CL necessitates a bit of an overhaul on all the
other CLs that are opened right now -- mostly renamings and removed files.

On Sun, Mar 7, 2010 at 11:25 AM, <zhoresh@gmail.com> wrote:

> LGTM
>
> Note that couple of the files you kill here are also killed by CL/248042
>
>
>
> http://codereview.appspot.com/224099/show
>

Expand All Messages | Collapse All Messages