Issue 224093: Use ProxyUriManager in CssRequestRewriter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 224093: Use ProxyUriManager in CssRequestRewriter (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 10 months ago by johnfargo

Modified:
15 years, 10 months ago

Reviewers:
zhoresh, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Replaces the use of LinkRewriter in CssRequestRewriter with ProxyUriManager.

Patch Set 2 : Synced to head. #

Total comments: 1

Created: 15 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -40 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriter.java	View	1	6 chunks	+58 lines, -19 lines	1 comment	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriterTest.java	View	1	8 chunks	+37 lines, -21 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

zhoresh

LGTM http://codereview.appspot.com/224093/diff/2001/2003 File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriter.java (right): http://codereview.appspot.com/224093/diff/2001/2003#newcode211 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriter.java:211: if (config.shouldRewriteURL(uri.getResource().toString())) { Since you check for shouldRewriteUrl ...

15 years, 10 months ago (2010-03-05 19:49:42 UTC) #3

johnfargo

15 years, 10 months ago (2010-03-08 23:00:00 UTC) #4

Good call, fixed, thx!

On Fri, Mar 5, 2010 at 11:49 AM, <zhoresh@gmail.com> wrote:

> LGTM
>
>
> http://codereview.appspot.com/224093/diff/2001/2003
> File
>
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriter.java
> (right):
>
> http://codereview.appspot.com/224093/diff/2001/2003#newcode211
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriter.java:211:
> if (config.shouldRewriteURL(uri.getResource().toString())) {
> Since you check for shouldRewriteUrl in line 67, do you really need to
> check again? one of the check is redundant.
>
>
> http://codereview.appspot.com/224093/show
>

Expand All Messages | Collapse All Messages