code review 224087: strings.Bytes -> []byte for documentation example, src/...

strings.Bytes -> []byte for documentation example, src/pkg/* comments, and htmlgen.go

[aam, 2010-03-01 17:51:04]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[aam, 2010-03-01 18:12:07]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2010-03-02 00:18:10]

LGTM

[aam, 2010-03-02 17:13:28]

looks like the files were updated outside of the 'hg' plugin without
closing the CL. there wasn't an email sent that they've been applied,
and an hg sync this morning says:

Removing unmodified files from CL 224087:
	doc/effective_go.html
	doc/htmlgen.go
	src/pkg/compress/zlib/reader.go
	src/pkg/websocket/client.go
CL 224087 has no files; suggest hg change -d 224087

is this now the correct course of action to close this CL?

[adg, 2010-03-02 21:45:28]

On 3 March 2010 04:13, andrey mirtchovski <mirtchovski@gmail.com> wrote:
> looks like the files were updated outside of the 'hg' plugin without
> closing the CL. there wasn't an email sent that they've been applied,
> and an hg sync this morning says:
>
> Removing unmodified files from CL 224087:
>        doc/effective_go.html
>        doc/htmlgen.go
>        src/pkg/compress/zlib/reader.go
>        src/pkg/websocket/client.go
> CL 224087 has no files; suggest hg change -d 224087
>
> is this now the correct course of action to close this CL?

It looks like the original 'hg submit' was aborted because of a
connectivity issue on my end. It must have gone part-way through the
process; far enough to update the files and put the revision into the
hg trunk, but stopping before the codereview extension part of the
process.

I tried to re-submit the CL, but it didn't work. If you can close it,
then please do. We may just have to leave it as-is.

Andrew

[rsc, 2010-03-02 21:47:00]

> I tried to re-submit the CL, but it didn't work. If you can close it,
> then please do. We may just have to leave it as-is.

Andrey can close it with hg change -d 224087.

Russ

[aam, 2010-03-02 22:09:10]

*** Abandoned ***