code review 224084: http: corrected comment for Response.GetHeader.

http: corrected comment for Response.GetHeader.

Fixes issue 622.

[adg, 2010-03-01 04:16:22]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-03-01 05:38:58]

fix should be the reverse: update the comment.
GetHeader is supposed to be the convenience function.
clients that need to check the presence of the header
can access the map directly.

russ

[adg, 2010-03-01 05:49:01]

I thought the benefit of GetHeader was wrapping the map key in
CanonicalHeaderKey?

On 1 March 2010 16:38, Russ Cox <rsc@golang.org> wrote:
> fix should be the reverse: update the comment.
> GetHeader is supposed to be the convenience function.
> clients that need to check the presence of the header
> can access the map directly.
>
> russ
>

[adg, 2010-03-02 00:17:15]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2010-03-02 18:17:05]

On Sun, Feb 28, 2010 at 21:48, Andrew Gerrand <adg@golang.org> wrote:
> I thought the benefit of GetHeader was wrapping the map key in
> CanonicalHeaderKey?

Then it has two benefits.  ;-)
Not having to deal with ok is definitely one of them.
This code is going to get revised soon to handle
multiple headers with the same key differently.
(Some servers don't respect the RFC, so we have
to change our approach.)  For now, I think the simplest
change is just to update the comment.

Russ

[rsc, 2010-03-02 21:43:10]

LGTM

http://codereview.appspot.com/224084/diff/12/1003
File src/pkg/http/response.go (right):

http://codereview.appspot.com/224084/diff/12/1003#newcode155
src/pkg/http/response.go:155: // GetHeader returns the value of the response
header with the given key.  If
Please break the line before "If", to avoid the orphan.

http://codereview.appspot.com/224084/diff/12/1003#newcode158
src/pkg/http/response.go:158: // key, it returns an empty string.  Keys are not
case sensitive.
change it to GetHeader -- it was too many nouns ago.

[adg, 2010-03-02 21:53:30]

*** Submitted as http://code.google.com/p/go/source/detail?r=ddb5c6704435 ***

http: corrected comment for Response.GetHeader.

Fixes issue 622.

R=rsc
CC=golang-dev
http://codereview.appspot.com/224084