src/pkg/go/parser/interface.go - Issue 224062: code review 224062: strings: delete Runes, Bytes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/go/parser/interface.go

Issue 224062: code review 224062: strings: delete Runes, Bytes (Closed)

Patch Set: code review 224062: strings: delete Runes, Bytes Created 15 years ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/go/parser/interface.go

===================================================================

--- a/src/pkg/go/parser/interface.go

+++ b/src/pkg/go/parser/interface.go

@@ -15,7 +15,6 @@

"io/ioutil"

"os"

pathutil "path"

- "strings"

)

@@ -27,7 +26,7 @@

if src != nil {

switch s := src.(type) {

case string:

- return strings.Bytes(s), nil

+ return []byte(s), nil

case []byte:

return s, nil

case *bytes.Buffer:

« no previous file with comments | « src/pkg/go/doc/comment.go ('k') | src/pkg/go/printer/nodes.go » ('j') | no next file with comments »