Change SafeHtmlMaker to declare variables per module

Previously, SafeHtmlMaker declared vars in one block, and assumed they
were visible in other blocks.

This fixes that in preparation for modular decomposition in CL 207079.
The extra var declarations can probably be optimized out in later
stages -- e.g. the repeated el___ and emitter___ declarations can be
optimized as in CL 214052.


Submitted @4009

[MikeSamuel, 2010-02-27 01:28:42]

ping

[MikeSamuel, 2010-03-04 22:31:43]

ping

[Jasvir, 2010-03-04 23:30:47]

http://codereview.appspot.com/224059/diff/1013/1016
File tests/com/google/caja/plugin/templates/TemplateCompilerTest.java (right):

http://codereview.appspot.com/224059/diff/1013/1016#newcode125
tests/com/google/caja/plugin/templates/TemplateCompilerTest.java:125: +
"function module() {"
I don't understand how this is ok.  Won't functions with the same name clobber
all but the last one?

[MikeSamuel, 2010-03-04 23:32:38]

http://codereview.appspot.com/224059/diff/1013/1016
File tests/com/google/caja/plugin/templates/TemplateCompilerTest.java (right):

http://codereview.appspot.com/224059/diff/1013/1016#newcode125
tests/com/google/caja/plugin/templates/TemplateCompilerTest.java:125: +
"function module() {"
This is just illustrative code put in by the test harness.

See line 823 of the same file.

[Jasvir, 2010-03-09 02:02:32]

LGTM

http://codereview.appspot.com/224059/diff/1013/1018
File tests/com/google/caja/plugin/templates/template-compiler-golden1-static.js
(right):

http://codereview.appspot.com/224059/diff/1013/1018#newcode1
tests/com/google/caja/plugin/templates/template-compiler-golden1-static.js:1:
function module() {
Note: Because of all of these functions named "module" this file appears to be
semantically incorrect javascript file but only because its the render of an
intermediate stage.