code review 224043: goinstall: an experiment in (external) package installation

misc/dashboard/godashboard/package.py

 # Copyright 2010 The Go Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style
 # license that can be found in the LICENSE file.
 
 # This is the server part of the package dashboard.
 # It must be run by App Engine.
 
 from google.appengine.api import memcache
 from google.appengine.runtime import DeadlineExceededError
 from google.appengine.ext import db
@@ skipping 14 matching lines @@
 # Storage model for package info recorded on server.
 # Just path, count, and time of last install.
 class Package(db.Model):
     path = db.StringProperty()
     web_url = db.StringProperty()  # derived from path
     count = db.IntegerProperty()
     last_install = db.DateTimeProperty()
 
 re_bitbucket = re.compile(r'^bitbucket\.org/[a-z0-9A-Z_.\-]+/[a-z0-9A-Z_.\-]+$')
 re_googlecode = re.compile(r'^[a-z0-9\-]+\.googlecode\.com/(svn|hg)$')
-re_github = re.compile(r'^github\.com/[a-z0-9A-Z_.\-]+/[a-z0-9A-Z_.\-]+\.git$')
+re_github = re.compile(r'^github\.com/[a-z0-9A-Z_.\-]+/[a-z0-9A-Z_.\-]+$')
 
 MaxPathLength = 100
 
 class PackagePage(webapp.RequestHandler):
     def get(self):
         if self.request.get('fmt') == 'json':
             return self.json()
 
         q = Package.all()
         q.order('-last_install')
@@ skipping 41 matching lines @@
         key = 'pkg-' + path
         p = Package.get_by_key_name(key)
         if p is None:
             # not in datastore - verify URL before creating
             if re_bitbucket.match(path):
                 check_url = 'http://' + path + '/?cmd=heads'
                 web = 'http://' + path + '/'
             elif re_github.match(path):
                 # github doesn't let you fetch the .git directory anymore.
                 # fetch .git/info/refs instead, like git clone would.
-                check_url = 'http://'+path+'/info/refs'
-                web = 'http://' + path[:-4]  # drop .git
+                check_url = 'http://'+path+'.git/info/refs'
+                web = 'http://' + path
             elif re_googlecode.match(path):
                 check_url = 'http://'+path
                 web = 'http://code.google.com/p/' + path[:path.index('.')]
             else:
                 logging.error('unrecognized path: %s', path)
                 return False
             if not self.can_get_url(check_url):
                 logging.error('cannot get %s', check_url)
                 return False
             p = Package(key_name = key, path = path, count = 0, web_url = web)
@@ skipping 14 matching lines @@
             logging.error('invalid path in post: %s', path)
             self.response.set_status(500)
             self.response.out.write('not ok')
 
 def main():
     app = webapp.WSGIApplication([('/package', PackagePage)], debug=True)
     run_wsgi_app(app)
 
 if __name__ == '__main__':
     main()