Issue 22370044: Support float config type in proof.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 22370044: Support float config type in proof.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by rharding

Modified:
10 years, 6 months ago

Reviewers:
bac, mp+194209

Visibility:
Public.

Description

Support float config type in proof. - if we don't support validating it then ignore it for now - add tests to each type we validate. https://code.launchpad.net/~rharding/charmworld/allow-more-config-types/+merge/194209 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -20 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmworld/lib/proof.py	View	2 chunks	+10 lines, -3 lines	1 comment	Download
M	charmworld/lib/tests/test_proof.py	View	1 chunk	+73 lines, -17 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bac

10 years, 6 months ago (2013-11-06 19:05:21 UTC) #2

The code LGTM but I'm not sure about the choice to not throw an error on unknown
types.

https://codereview.appspot.com/22370044/diff/1/charmworld/lib/proof.py
File charmworld/lib/proof.py (right):

https://codereview.appspot.com/22370044/diff/1/charmworld/lib/proof.py#newcode43
charmworld/lib/proof.py:43: return
Shouldn't an invalid type be an error or at least a warning?

Expand All Messages | Collapse All Messages