code review 2233044: godoc: show "Last update" info for directory listings.

godoc: show "Last update" info for directory listings.

Use -timestamps=false flag to disable.

(This used to be shown on the front-page below the
build information with the old godoc. However, the
time stamps are directory-specific and should be
shown with the directory.)

[gri, 2010-09-16 20:06:15]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-09-16 20:12:12]

Can we have a flag to disable them?
It makes sense for a local installation
where files are changing, but it doesn't
make sense for golang.org where we
push new files with each weekly release.
Saying the page is updated in the last
few minutes is not accurate there, even
if the directory was in fact scanned in
the last few minutes.

[gri, 2010-09-16 20:19:52]

Sure. Except for server restarts, golang.org would actually show the time of
a new release (more or less). But I guess we have server restarts...

What should the default be?
- gri

On Thu, Sep 16, 2010 at 1:12 PM, <rsc@google.com> wrote:

> Can we have a flag to disable them?
> It makes sense for a local installation
> where files are changing, but it doesn't
> make sense for golang.org where we
> push new files with each weekly release.
> Saying the page is updated in the last
> few minutes is not accurate there, even
> if the directory was in fact scanned in
> the last few minutes.
>
>
>
> http://codereview.appspot.com/2233044/
>

[gri, 2010-09-16 20:23:09]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[gri, 2010-09-16 20:28:18]

PS: In retrospect, I am inclined to set the default to true. We have scripts
to launch godoc so it doesn't matter. Everybody else running godoc as a
server locally shouldn't have to worry about setting the flag, and by
default the timestamps should be shown. Objections?
- gri

On Thu, Sep 16, 2010 at 1:23 PM, <gri@golang.org> wrote:

> Hello rsc (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
> http://codereview.appspot.com/2233044/
>

[rsc1, 2010-09-16 20:34:37]

LGTM

I agree that true is the right default.

[gri, 2010-09-16 20:45:44]

*** Submitted as http://code.google.com/p/go/source/detail?r=e8e5e0fb8ef7 ***

godoc: show "Last update" info for directory listings.

Use -timestamps=false flag to disable.

(This used to be shown on the front-page below the
build information with the old godoc. However, the
time stamps are directory-specific and should be
shown with the directory.)

R=rsc
CC=golang-dev
http://codereview.appspot.com/2233044