support setContentType method

support setContentType method

ibus now supports setContentType method, if an application input some
password, the password will not be shown.

BUG=rhbz#1027029

[Peng Wu, 2014-02-10 03:10:07]

Please review this patch, thanks.

[Peng, 2014-02-10 16:00:32]

https://codereview.appspot.com/22330043/diff/1/src/PYBopomofoEngine.h
File src/PYBopomofoEngine.h (right):

https://codereview.appspot.com/22330043/diff/1/src/PYBopomofoEngine.h#newcode40
src/PYBopomofoEngine.h:40: void setContentType (guint purpose, guint hints);
Could you please try to put those logic to base class? Seems Pinyin and Bopomofo
are use similar logic for input_purpose.

[Peng Wu, 2014-02-12 05:13:32]

Sorry, I tried to move those logic to base class, but hard to move all.

[Peng, 2014-02-12 14:01:01]

https://codereview.appspot.com/22330043/diff/20001/src/PYPinyinEngine.cc
File src/PYPinyinEngine.cc (right):

https://codereview.appspot.com/22330043/diff/20001/src/PYPinyinEngine.cc#newc...
src/PYPinyinEngine.cc:88: #endif
How about add a helper function in base class to test it to avoid checking ibus
version everywhere?

for example:

bool Engine::contentIsPassword() {
#if IBUS_CHECK_VERSION(...)
  return m_input_purpose == PASSWORD;
#else
  return false;
#endif
}

https://codereview.appspot.com/22330043/diff/20001/src/PYPinyinEngine.cc#newc...
src/PYPinyinEngine.cc:205: m_input_purpose = IBUS_INPUT_PURPOSE_FREE_FORM;
How about reset m_input_purpose in base class's reset() function, and call it in
PinyinEngine::reset() and BopomofoEngine::reset()?

[Peng Wu, 2014-02-13 03:16:10]

On 2014/02/12 14:01:01, Peng wrote:
> https://codereview.appspot.com/22330043/diff/20001/src/PYPinyinEngine.cc
> File src/PYPinyinEngine.cc (right):
> 
>
https://codereview.appspot.com/22330043/diff/20001/src/PYPinyinEngine.cc#newc...
> src/PYPinyinEngine.cc:88: #endif
> How about add a helper function in base class to test it to avoid checking
ibus
> version everywhere?
> 
> for example:
> 
> bool Engine::contentIsPassword() {
> #if IBUS_CHECK_VERSION(...)
>   return m_input_purpose == PASSWORD;
> #else
>   return false;
> #endif
> }
> 

I just suspect that this may introduce more code in the patch.

>
https://codereview.appspot.com/22330043/diff/20001/src/PYPinyinEngine.cc#newc...
> src/PYPinyinEngine.cc:205: m_input_purpose = IBUS_INPUT_PURPOSE_FREE_FORM;
> How about reset m_input_purpose in base class's reset() function, and call it
in
> PinyinEngine::reset() and BopomofoEngine::reset()?

The problem is that the reset method is defined as:
FUNCTION(reset,       reset)

But if you want, I can change the code according to your comments.

[Peng, 2014-02-13 04:38:02]

On 2014/02/13 03:16:10, Peng Wu wrote:
> On 2014/02/12 14:01:01, Peng wrote:
> > https://codereview.appspot.com/22330043/diff/20001/src/PYPinyinEngine.cc
> > File src/PYPinyinEngine.cc (right):
> > 
> >
>
https://codereview.appspot.com/22330043/diff/20001/src/PYPinyinEngine.cc#newc...
> > src/PYPinyinEngine.cc:88: #endif
> > How about add a helper function in base class to test it to avoid checking
> ibus
> > version everywhere?
> > 
> > for example:
> > 
> > bool Engine::contentIsPassword() {
> > #if IBUS_CHECK_VERSION(...)
> >   return m_input_purpose == PASSWORD;
> > #else
> >   return false;
> > #endif
> > }
> > 
> 
> I just suspect that this may introduce more code in the patch.
> 

Maybe it is true. But i think it is not good to check version in alot of places.

> >
>
https://codereview.appspot.com/22330043/diff/20001/src/PYPinyinEngine.cc#newc...
> > src/PYPinyinEngine.cc:205: m_input_purpose = IBUS_INPUT_PURPOSE_FREE_FORM;
> > How about reset m_input_purpose in base class's reset() function, and call
it
> in
> > PinyinEngine::reset() and BopomofoEngine::reset()?
> 
> The problem is that the reset method is defined as:
> FUNCTION(reset,       reset)
> 
> But if you want, I can change the code according to your comments.

Don't understand. I think reset is just a virtual function.

[Peng Wu, 2014-02-13 05:21:43]

On 2014/02/13 04:38:02, Peng wrote:
>
https://codereview.appspot.com/22330043/diff/20001/src/PYPinyinEngine.cc#newc...
> > > src/PYPinyinEngine.cc:205: m_input_purpose = IBUS_INPUT_PURPOSE_FREE_FORM;
> > > How about reset m_input_purpose in base class's reset() function, and call
> it
> > in
> > > PinyinEngine::reset() and BopomofoEngine::reset()?
> > 
> > The problem is that the reset method is defined as:
> > FUNCTION(reset,       reset)
> > 
> > But if you want, I can change the code according to your comments.
> 
> Don't understand. I think reset is just a virtual function.

Because the reset function is implemented by a macro in the PYEngine.cc file.

If I want to change the reset function, I need to expand that macro manually.

[Peng Wu, 2014-02-13 09:55:29]

Just ignore the previous comment, I will check it again tomorrow.

[Peng Wu, 2014-02-14 02:53:31]

Please review this new patch set, thanks.

[Peng, 2014-02-14 03:28:11]

On 2014/02/14 02:53:31, Peng Wu wrote:
> Please review this new patch set, thanks.

lgtm

[Peng, 2014-02-19 15:59:05]

On 2014/02/14 03:28:11, Peng wrote:
> On 2014/02/14 02:53:31, Peng Wu wrote:
> > Please review this new patch set, thanks.
> 
> lgtm

landed. Please close this CL.