Taming osapi

* filters out caja properties from native json.stringify
* tames methods created using osapi.registerMethod_
  - the latter should be reviewed particularly carefully

[johnfargo, 2010-03-08 22:45:11]

nits

http://codereview.appspot.com/223109/diff/6001/4004
File features/src/main/javascript/features/core.json/json.js (right):

http://codereview.appspot.com/223109/diff/6001/4004#newcode56
features/src/main/javascript/features/core.json/json.js:56: if (!/___$/.test(k))
worth precompiling regex?

http://codereview.appspot.com/223109/diff/6001/4004#newcode57
features/src/main/javascript/features/core.json/json.js:57: return v;
worth explicitly returning null? per
https://developer.mozilla.org/En/Using_JSON_in_Firefox, only "null" is
explicitly labeled as kosher for filtering.

http://codereview.appspot.com/223109/diff/6001/4003
File
java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java
(right):

http://codereview.appspot.com/223109/diff/6001/4003#newcode242
java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java:242:
executeAllPageTests("osapi/appdataTest", true /* caja */);
nit: separate into 2 tests

[Jasvir, 2010-03-09 01:42:51]

http://codereview.appspot.com/223109/diff/6001/4004
File features/src/main/javascript/features/core.json/json.js (right):

http://codereview.appspot.com/223109/diff/6001/4004#newcode56
features/src/main/javascript/features/core.json/json.js:56: if (!/___$/.test(k))
On 2010/03/08 22:45:11, johnfargo wrote:
> worth precompiling regex?

Done.

http://codereview.appspot.com/223109/diff/6001/4004#newcode57
features/src/main/javascript/features/core.json/json.js:57: return v;
On 2010/03/08 22:45:11, johnfargo wrote:
> worth explicitly returning null? per
> https://developer.mozilla.org/En/Using_JSON_in_Firefox, only "null" is
> explicitly labeled as kosher for filtering.

Done.

http://codereview.appspot.com/223109/diff/6001/4003
File
java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java
(right):

http://codereview.appspot.com/223109/diff/6001/4003#newcode242
java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java:242:
executeAllPageTests("osapi/appdataTest", true /* caja */);
On 2010/03/08 22:45:11, johnfargo wrote:
> nit: separate into 2 tests

Done.

[johnfargo, 2010-03-09 01:52:53]

LGTM