Issue 2231043: Some cleanup of the JsonML that I'm working on with closure

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2231043: Some cleanup of the JsonML that I'm working on with closure

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by MikeSamuel

Modified:
15 years, 6 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

This replaces the jsonml.jar with one that got rid of a node-type that was undocumented and unused in es-lab. Also: - gets rid of a reference to it in JsonMLConverter - cleanup warnings around NaN check in NumberLiteral. - misc. other warning cleanup.

Patch Set 1 #

Patch Set 2 : Some cleanup of the JsonML that I'm working on with closure #

Patch Set 3 : Some cleanup of the JsonML that I'm working on with closure #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -20 lines)			Patch
M	src/com/google/caja/demos/playground/client/ui/PlaygroundEditor.java	View	1 2	3 chunks	+6 lines, -5 lines	0 comments	Download
M	src/com/google/caja/demos/playground/client/ui/PlaygroundView.java	View	1 2	3 chunks	+3 lines, -2 lines	0 comments	Download
M	src/com/google/caja/parser/html/OpenElementStack.java	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/com/google/caja/parser/js/CajoledModuleExpression.java	View	2	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/parser/js/Elision.java	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/com/google/caja/parser/js/JsonMLCompatible.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/parser/js/JsonMLConverter.java	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/com/google/caja/parser/js/NumberLiteral.java	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/tools/EnumsToJs.java	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/com/google/caja/util/RhinoExecutor.java	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A	third_party/java/jsonml/LICENSE	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	third_party/java/jsonml/README	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/java/jsonml/jsonml.jar	View		Binary file		0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Jasvir

LGTM jsonml.jar is missing README and LICENSE files. Please add those.

15 years, 6 months ago (2010-09-20 20:18:37 UTC) #3

MikeSamuel

15 years, 6 months ago (2010-09-20 21:09:57 UTC) #4

done

2010/9/20  <jasvir@gmail.com>:
> LGTM
>
> jsonml.jar is missing README and LICENSE files.  Please add those.
>
> http://codereview.appspot.com/2231043/
>

Expand All Messages | Collapse All Messages