Issue 223094: code review 223094: Set DNS config defaults to the same values as various C DNS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 223094: code review 223094: Set DNS config defaults to the same values as various C DNS (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by stephenm

Modified:
15 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

net: correct DNS configuration Set defaults to the same values as various C DNS resolver libraries. Use the timeout value from the configuration. Fixes issue 632.

Patch Set 1 #

Patch Set 2 : code review 223094: Set DNS config defaults to the same values as various C DNS #

Patch Set 3 : code review 223094: net: correct DNS configuration #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/pkg/net/dnsclient.go	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/net/dnsconfig.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

stephenm

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-02 05:30:14 UTC) #1

rsc

LGTM please run "hg change" to edit description to have the form "package: one-line summary\n\nmore ...

15 years ago (2010-03-02 18:08:47 UTC) #2

stephenm

15 years ago (2010-03-03 04:25:33 UTC) #3

*** Submitted as 88d305c3f261 ***

net: correct DNS configuration

Set defaults to the same values as various C DNS resolver libraries.
Use the timeout value from the configuration.
Fixes issue 632.

R=rsc
CC=golang-dev
http://codereview.appspot.com/223094

Expand All Messages | Collapse All Messages