Issue 223093: Use ProxyUriManager in CajaCssSanitizer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 223093: Use ProxyUriManager in CajaCssSanitizer (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 10 months ago by johnfargo

Modified:
15 years, 10 months ago

Reviewers:
zhoresh, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Replaces LinkRewriter with ProxyUriManager for CajaCssSanitizer. The actual implementation will come from a prior CL updating SanitizingProxyingLinkRewriter to be a ProxyUriManager.

Patch Set 1 #

Patch Set 2 : Synced to head. #

Total comments: 1

Created: 15 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -25 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizer.java	View	1	8 chunks	+28 lines, -9 lines	1 comment	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizerTest.java	View	1	4 chunks	+14 lines, -16 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

zhoresh

LGTM The more I read, the more I like the original interface LinkRewriter. Maybe UriManager ...

15 years, 10 months ago (2010-03-05 18:41:50 UTC) #3

johnfargo

15 years, 10 months ago (2010-03-08 22:53:52 UTC) #4

On Fri, Mar 5, 2010 at 10:41 AM, <zhoresh@gmail.com> wrote:

> LGTM
>
> The more I read, the more I like the original interface LinkRewriter.
> Maybe UriManager should at least implement the LinkRewriter interface?
>

As perhaps noted elsewhere, UriManager really is LinkRewriter, but provided
better-structured data (Uri in, Uri out), with batching. A single-item
interface could be useful though IMO that's really just a single-List-item
passthrough helper function.

>
>
>
> http://codereview.appspot.com/223093/diff/1001/2002
> File
>
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizer.java
> (right):
>
> http://codereview.appspot.com/223093/diff/1001/2002#newcode152
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizer.java:152:
> rewriteUri(imageRewriter, uri, linkContext));
> Maybe put rewrite function in ProxyUriManager that do what rewriteUri
> does.

(same comment as above)

>
>
> http://codereview.appspot.com/223093/show
>

Expand All Messages | Collapse All Messages