Issue 223087: code review 223087: codereview.py: fix for compatibility with hg >=1.4.3

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 223087: code review 223087: codereview.py: fix for compatibility with hg >=1.4.3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by adg

Modified:
15 years ago

Reviewers:

CC:
rsc, iant, golang-dev

Visibility:
Public.

Description

codereview.py: fix for compatibility with hg >=1.4.3 hg.parseurl now returns a two-value tuple; codereview.py expected 3. Changed to merely take the first return value.

Patch Set 1 #

Patch Set 2 : code review 223087: codereview.py: fix for compatibility with hg >=1.4.3 #

Patch Set 3 : code review 223087: codereview.py: fix for compatibility with hg >=1.4.3 #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lib/codereview/codereview.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello rsc, iant (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-02 00:05:38 UTC) #1

adg

15 years ago (2010-03-02 22:03:33 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ebd0eee4624a ***

codereview.py: fix for compatibility with hg >=1.4.3

hg.parseurl now returns a two-value tuple; codereview.py expected 3.
Changed to merely take the first return value.

R=rsc, iant
CC=golang-dev
http://codereview.appspot.com/223087

Expand All Messages | Collapse All Messages