Issue 223075: code review 223075: testing/benchmark: paranoia - make sure n always grows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 223075: code review 223075: testing/benchmark: paranoia - make sure n always grows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
15 years ago

Reviewers:

CC:
Bill Neubauer, golang-dev

Visibility:
Public.

Description

testing/benchmark: paranoia - make sure n always grows

Patch Set 1 #

Patch Set 2 : code review 223075: testing/benchmark: paranoia - make sure n always grows #

Patch Set 3 : code review 223075: testing/benchmark: paranoia - make sure n always grows #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	src/pkg/testing/benchmark.go	View	1	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello wcn (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-02-27 00:43:09 UTC) #1

Bill Neubauer

On 2010/02/27 00:43:09, rsc wrote: > Hello wcn (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

15 years ago (2010-02-27 01:15:44 UTC) #2

rsc

15 years ago (2010-02-27 01:18:51 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=07a8ae342d04 ***

testing/benchmark: paranoia - make sure n always grows

R=wcn
CC=golang-dev
http://codereview.appspot.com/223075

Expand All Messages | Collapse All Messages