src/cmd/8g/cgen.c - Issue 223070: code review 223070: 8g: fix out of register bug in byte(x) code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/8g/cgen.c

Issue 223070: code review 223070: 8g: fix out of register bug in byte(x) code (Closed)

Patch Set: code review 223070: 8g: fix out of register bug in byte(x) code Created 15 years ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/8g/cgen.c

===================================================================

--- a/src/cmd/8g/cgen.c

+++ b/src/cmd/8g/cgen.c

@@ -215,14 +215,9 @@

break;

}

mgen(nl, &n1, res);

- if(n->type->width > widthptr)

- tempname(&n2, n->type);

- else

- regalloc(&n2, n->type, res);

+ tempname(&n2, n->type);

gmove(&n1, &n2);

gmove(&n2, res);

- if(n2.op == OREGISTER)

- regfree(&n2);

mfree(&n1);

break;

« no previous file with comments | « no previous file | no next file » | no next file with comments »