code review 223059: use []byte("abc") in place of []byte{'a', 'b', 'c'}

use []byte("abc") in place of []byte{'a', 'b', 'c'}

[rsc, 2010-02-26 00:11:15]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[gri1, 2010-02-26 00:13:50]

LGTM

On Thu, Feb 25, 2010 at 4:11 PM,  <rsc@golang.org> wrote:
> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> use []byte("abc") in place of []byte{'a', 'b', 'c'}
>
> Please review this at http://codereview.appspot.com/223059/show
>
> Affected files:
>  M src/pkg/asn1/asn1_test.go
>  M src/pkg/fmt/print.go
>  M src/pkg/go/ast/filter.go
>  M src/pkg/go/printer/printer.go
>  M src/pkg/go/scanner/scanner.go
>
>
> Index: src/pkg/asn1/asn1_test.go
> ===================================================================
> --- a/src/pkg/asn1/asn1_test.go
> +++ b/src/pkg/asn1/asn1_test.go
> @@ -276,7 +276,7 @@
>        unmarshalTest{[]byte{0x02, 0x01, 0x10}, newInt(16)},
>        unmarshalTest{[]byte{0x13, 0x04, 't', 'e', 's', 't'},
> newString("test")},
>        unmarshalTest{[]byte{0x16, 0x04, 't', 'e', 's', 't'},
> newString("test")},
> -       unmarshalTest{[]byte{0x16, 0x04, 't', 'e', 's', 't'}, &RawValue{0,
> 22, false, []byte{'t', 'e', 's', 't'}}},
> +       unmarshalTest{[]byte{0x16, 0x04, 't', 'e', 's', 't'}, &RawValue{0,
> 22, false, []byte("test")}},
>        unmarshalTest{[]byte{0x04, 0x04, 1, 2, 3, 4}, &RawValue{0, 4, false,
> []byte{1, 2, 3, 4}}},
>        unmarshalTest{[]byte{0x30, 0x03, 0x81, 0x01, 0x01},
> &TestContextSpecificTags{1}},
>        unmarshalTest{[]byte{0x30, 0x08, 0xa1, 0x03, 0x02, 0x01, 0x01, 0x02,
> 0x01, 0x02}, &TestContextSpecificTags2{1, 2}},
> Index: src/pkg/fmt/print.go
> ===================================================================
> --- a/src/pkg/fmt/print.go
> +++ b/src/pkg/fmt/print.go
> @@ -87,15 +87,15 @@
>  // Some constants in the form of bytes, to avoid string overhead.
>  // Needlessly fastidious, I suppose.
>  var (
> -       trueBytes       = []byte{'t', 'r', 'u', 'e'}
> -       falseBytes      = []byte{'f', 'a', 'l', 's', 'e'}
> -       commaSpaceBytes = []byte{',', ' '}
> -       nilAngleBytes   = []byte{'<', 'n', 'i', 'l', '>'}
> -       nilParenBytes   = []byte{'(', 'n', 'i', 'l', ')'}
> -       nilBytes        = []byte{'n', 'i', 'l'}
> -       mapBytes        = []byte{'m', 'a', 'p', '['}
> -       missingBytes    = []byte{'m', 'i', 's', 's', 'i', 'n', 'g'}
> -       extraBytes      = []byte{'?', '(', 'e', 'x', 't', 'r', 'a', ' '}
> +       trueBytes       = []byte("true")
> +       falseBytes      = []byte("false")
> +       commaSpaceBytes = []byte(", ")
> +       nilAngleBytes   = []byte("<nil>")
> +       nilParenBytes   = []byte("(nil)")
> +       nilBytes        = []byte("nil")
> +       mapBytes        = []byte("map[")
> +       missingBytes    = []byte("missing")
> +       extraBytes      = []byte("?(extra ")
>  )
>
>  // State represents the printer state passed to custom formatters.
> Index: src/pkg/go/ast/filter.go
> ===================================================================
> --- a/src/pkg/go/ast/filter.go
> +++ b/src/pkg/go/ast/filter.go
> @@ -192,7 +192,7 @@
>  // separator is an empty //-style comment that is interspersed between
>  // different comment groups when they are concatenated into a single group
>  //
> -var separator = &Comment{noPos, []byte{'/', '/'}}
> +var separator = &Comment{noPos, []byte("//")}
>
>
>  // MergePackageFiles creates a file AST by merging the ASTs of the
> Index: src/pkg/go/printer/printer.go
> ===================================================================
> --- a/src/pkg/go/printer/printer.go
> +++ b/src/pkg/go/printer/printer.go
> @@ -526,7 +526,7 @@
>        // with the opening /*, otherwise align the text with the other
>        // lines.
>        last := lines[len(lines)-1]
> -       closing := []byte{'*', '/'}
> +       closing := []byte("*/")
>        i := bytes.Index(last, closing)
>        if isBlank(last[0:i]) {
>                // last line only contains closing */
> Index: src/pkg/go/scanner/scanner.go
> ===================================================================
> --- a/src/pkg/go/scanner/scanner.go
> +++ b/src/pkg/go/scanner/scanner.go
> @@ -145,7 +145,7 @@
>  }
>
>
> -var prefix = []byte{'l', 'i', 'n', 'e', ' '} // "line "
> +var prefix = []byte("line ")
>
>  func (S *Scanner) scanComment(pos token.Position) {
>        // first '/' already consumed
>
>
>

[rsc, 2010-02-26 00:43:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=e8468949a421 ***

use []byte("abc") in place of []byte{'a', 'b', 'c'}

R=gri
CC=golang-dev
http://codereview.appspot.com/223059