Issue 223058: code review 223058: go/printer, gofmt: align comments in multi-line express...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 223058: code review 223058: go/printer, gofmt: align comments in multi-line express... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by gri

Modified:
14 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/printer, gofmt: align comments in multi-line expression lists - gofmt -w src misc - improves several lists and fixes minor degradation introduced with the fix for issue 628 - removed some dead code (stringList)

Patch Set 1 #

Patch Set 2 : code review 223058: go/printer, gofmt: align comments in multi-line express... #

Patch Set 3 : code review 223058: go/printer, gofmt: align comments in multi-line express... #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -67 lines)			Patch
M	src/cmd/cgo/gcc.go	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	src/cmd/godoc/godoc.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/4s/xs.go	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	1	3 chunks	+22 lines, -19 lines	0 comments	Download
M	src/pkg/go/printer/printer.go	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.golden	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.input	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/expressions.raw	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/pkg/go/scanner/scanner_test.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/http/response_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/strconv/decimal.go	View		1 chunk	+25 lines, -25 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 2 months ago (2010-02-26 00:03:25 UTC) #1

gri

14 years, 2 months ago (2010-02-26 00:07:57 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=7dc7027124b8 ***

go/printer, gofmt: align comments in multi-line expression lists
- gofmt -w src misc
- improves several lists and fixes minor degradation introduced
  with the fix for issue 628
- removed some dead code (stringList)

R=rsc
CC=golang-dev
http://codereview.appspot.com/223058

Expand All Messages | Collapse All Messages