Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(279)

Issue 2226041: Common container: updates (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by mhermanto
Modified:
15 years, 3 months ago
Reviewers:
zhoresh, dev-remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

- Push down caching mechanism to service for gadget metadata. - Now builds full response from partial request/response. - Allow defaultable view (ie: if requested view does not exist, fallback to view=default). - More friendly runtime error checking. - Per-gadget error reporting.

Patch Set 1 : Update patch #

Total comments: 3

Patch Set 2 : Update patch to address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -111 lines) Patch
features/src/main/javascript/features/container/constant.js View 2 chunks +2 lines, -0 lines 0 comments Download
features/src/main/javascript/features/container/container.js View 6 chunks +44 lines, -20 lines 0 comments Download
features/src/main/javascript/features/container/gadget_holder.js View 4 chunks +3 lines, -21 lines 0 comments Download
features/src/main/javascript/features/container/gadget_site.js View 1 4 chunks +38 lines, -33 lines 0 comments Download
features/src/main/javascript/features/container/service.js View 1 5 chunks +92 lines, -33 lines 0 comments Download
features/src/main/javascript/features/container/util.js View 2 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 5
mhermanto
15 years, 4 months ago (2010-09-15 23:48:43 UTC) #1
zhoresh
http://codereview.appspot.com/2226041/diff/5002/features/src/main/javascript/features/container/gadget_site.js File features/src/main/javascript/features/container/gadget_site.js (right): http://codereview.appspot.com/2226041/diff/5002/features/src/main/javascript/features/container/gadget_site.js#newcode246 features/src/main/javascript/features/container/gadget_site.js:246: if (renderParams[shindig.container.RenderParam.ALLOW_DEFAULT_VIEW] && !viewInfo) { nit: I would reverse ...
15 years, 4 months ago (2010-09-16 20:54:15 UTC) #2
mhermanto
On Thu, Sep 16, 2010 at 1:54 PM, <zhoresh@gmail.com> wrote: > > > http://codereview.appspot.com/2226041/diff/5002/features/src/main/javascript/features/container/gadget_site.js > ...
15 years, 4 months ago (2010-09-17 04:22:12 UTC) #3
mhermanto
Update patch to address comments
15 years, 4 months ago (2010-09-17 04:24:14 UTC) #4
zhoresh
15 years, 4 months ago (2010-09-20 19:42:37 UTC) #5
lgtm, I thought the cache is new. 

But we should handle expiation which might require a change in the GadgetHandler
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b