Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 22210043: Adjust svnversion glue for unversioned trees in svn 1.7. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by kpreid2
Modified:
12 years, 4 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Subversion 1.7 changed svnversion to produce "Unversioned directory" or other messages instead of "exported"; update our svnversion usage to canonicalize all 1.7 and pre-1.7 results to "unknown" for use as our version number. @r5624

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adjust svnversion glue for unversioned trees in svn 1.7. #

Patch Set 3 : Adjust svnversion glue for unversioned trees in svn 1.7. #

Total comments: 2

Patch Set 4 : Adjust svnversion glue for unversioned trees in svn 1.7. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M build.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/svnversion-nocolon View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9
kpreid2
12 years, 4 months ago (2013-11-05 22:43:03 UTC) #1
felix8a
https://codereview.appspot.com/22210043/diff/1/tools/svnversion-nocolon File tools/svnversion-nocolon (right): https://codereview.appspot.com/22210043/diff/1/tools/svnversion-nocolon#newcode8 tools/svnversion-nocolon:8: sed -E -e 's/^(Unversioned.*|Uncommitted.*|exported)$/unknown/' \ sed -E is a ...
12 years, 4 months ago (2013-11-05 23:02:13 UTC) #2
kpreid2
Subversion 1.7 changed svnversion to produce "Unversioned directory" or other messages instead of "exported"; update ...
12 years, 4 months ago (2013-11-05 23:22:23 UTC) #3
kpreid2
https://codereview.appspot.com/22210043/diff/1/tools/svnversion-nocolon File tools/svnversion-nocolon (right): https://codereview.appspot.com/22210043/diff/1/tools/svnversion-nocolon#newcode8 tools/svnversion-nocolon:8: sed -E -e 's/^(Unversioned.*|Uncommitted.*|exported)$/unknown/' \ On 2013/11/05 23:02:13, felix8a ...
12 years, 4 months ago (2013-11-05 23:23:13 UTC) #4
kpreid2
Subversion 1.7 changed svnversion to produce "Unversioned directory" or other messages instead of "exported"; update ...
12 years, 4 months ago (2013-11-05 23:33:22 UTC) #5
kpreid2
Oops, missed snapshot, fixed.
12 years, 4 months ago (2013-11-05 23:33:42 UTC) #6
felix8a
lgtm https://codereview.appspot.com/22210043/diff/40001/tools/svnversion-nocolon File tools/svnversion-nocolon (right): https://codereview.appspot.com/22210043/diff/40001/tools/svnversion-nocolon#newcode9 tools/svnversion-nocolon:9: tr 'A-Z' 'a-z' why not fold the tr ...
12 years, 4 months ago (2013-11-05 23:41:38 UTC) #7
kpreid2
Subversion 1.7 changed svnversion to produce "Unversioned directory" or other messages instead of "exported"; update ...
12 years, 4 months ago (2013-11-05 23:48:02 UTC) #8
kpreid2
12 years, 4 months ago (2013-11-05 23:49:01 UTC) #9
https://codereview.appspot.com/22210043/diff/40001/tools/svnversion-nocolon
File tools/svnversion-nocolon (right):

https://codereview.appspot.com/22210043/diff/40001/tools/svnversion-nocolon#n...
tools/svnversion-nocolon:9: tr 'A-Z' 'a-z'
On 2013/11/05 23:41:39, felix8a wrote:
> why not fold the tr into the perl too?

No reason, looking too narrowly. Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b