Issue 22190043: A false positive occurs when a user specifies a using declaration for a stream operator:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 22190043: A false positive occurs when a user specifies a using declaration for a stream operator: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by erg

Modified:
10 years, 10 months ago

Reviewers:

Base URL:
https://google-styleguide.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

A false positive occurs when a user specifies a using declaration for a stream operator: 10: using ns::operator<<; file.cpp:10: Missing spaces around << [whitespace/operators] [3] The regular expression has been updated to find this valid use case of the << text string. Committed: 118

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	cpplint/cpplint.py	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	M	cpplint/cpplint_unittest.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

erg

10 years, 10 months ago (2013-11-05 22:28:12 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r118 (presubmit successful).

Expand All Messages | Collapse All Messages