Issue 221790043: Fixed model.entry_key problem.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 221790043: Fixed model.entry_key problem. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by cmassaro

Modified:
10 years, 1 month ago

Reviewers:
vadimsh, M-A

CC:
swarming-eng_googlegroups.com

Base URL:
https://code.google.com/p/swarming@master

Visibility:
Public.

More Reviews

Description

Fixed model.entry_key problem. R=vadimsh@chromium.org, maruel@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=default&r=b2c4b21331f1b3a650d55bcea5c8ccb22c439d78

Patch Set 2 : Removed AssertionError Handling #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -9 lines)			Patch
	M	appengine/isolate/endpoint_handlers_api.py	View	1	5 chunks	+12 lines, -9 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

vadimsh

https://codereview.appspot.com/221790043/diff/1/appengine/isolate/endpoint_handlers_api.py File appengine/isolate/endpoint_handlers_api.py (right): https://codereview.appspot.com/221790043/diff/1/appengine/isolate/endpoint_handlers_api.py#newcode147 appengine/isolate/endpoint_handlers_api.py:147: except (AssertionError, ValueError) as error: AssertionErrors should never ever ...

10 years, 1 month ago (2015-03-25 18:38:03 UTC) #2

cmassaro

10 years, 1 month ago (2015-03-25 18:51:07 UTC) #3

cmassaro

10 years, 1 month ago (2015-03-25 21:12:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b2c4b21331f1b3a650d55bcea5c8ccb22c439d78 (presubmit successful).

Expand All Messages | Collapse All Messages