Issue 2213046: Fix bug where global reads weren't getting fastpath.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2213046: Fix bug where global reads weren't getting fastpath. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 9 months ago by metaweta

Modified:
15 years, 9 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Fix bug where global reads weren't getting fastpath.

Patch Set 2 : Fix bug where global reads weren't getting fastpath. #

Created: 15 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	src/com/google/caja/parser/quasiliteral/ES53Rewriter.java	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
	M	tests/com/google/caja/parser/quasiliteral/ES53RewriterTest.java	View		2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Jasvir

http://codereview.appspot.com/2213046/diff/1/src/com/google/caja/parser/quasiliteral/ES53Rewriter.java File src/com/google/caja/parser/quasiliteral/ES53Rewriter.java (right): http://codereview.appspot.com/2213046/diff/1/src/com/google/caja/parser/quasiliteral/ES53Rewriter.java#newcode778 src/com/google/caja/parser/quasiliteral/ES53Rewriter.java:778: "IMPORTS___.@fp ? IMPORTS___.@v : ___.ri(IMPORTS___, @vname)", Might it be ...

15 years, 9 months ago (2010-09-22 18:45:56 UTC) #2

LGTM

Expand All Messages | Collapse All Messages