Issue 2205042: code review 2205042: fix various comments

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2205042: code review 2205042: fix various comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by gri

Modified:
14 years, 6 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

fix various comments (os package comments were duplicates)

Patch Set 1 #

Patch Set 2 : code review 2205042: fix various comments #

Patch Set 3 : code review 2205042: fix various comments #

Patch Set 4 : code review 2205042: fix various comments #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -5 lines)			Patch
M	src/pkg/go/doc/comment.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/file_unix.go	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/pkg/os/file_windows.go	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 6 months ago (2010-09-16 22:14:48 UTC) #1

rsc

I'm afraid that this will hide bugs. I would rather find the packages that are ...

14 years, 6 months ago (2010-09-16 23:51:21 UTC) #2

gri

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 6 months ago (2010-09-17 00:28:37 UTC) #3

gri

PTAL - gri On Thu, Sep 16, 2010 at 4:51 PM, Russ Cox <rsc@golang.org> wrote: ...

14 years, 6 months ago (2010-09-17 00:31:11 UTC) #4

gri

14 years, 6 months ago (2010-09-17 01:21:07 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=1a60f450b800 ***

fix various comments

(os package comments were duplicates)

R=rsc
CC=golang-dev
http://codereview.appspot.com/2205042

Expand All Messages | Collapse All Messages