Issue 220500043: Put PropertyPanel at bottom right when desktop is KDE.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 220500043: Put PropertyPanel at bottom right when desktop is KDE. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 1 month ago by fujiwara

Modified:
9 years, 1 month ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Put PropertyPanel at bottom right when desktop is KDE Monitor _NET_WORKAREA atom because PropertyPanel runs before KDE5 panel runs. Allocate button sizes on PropertyPanel correctly for KDE5. TEST=ui/gtk3/ibus-ui-gtk3

Patch Set 1 #

Total comments: 4

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -47 lines)			Patch
	M	ui/gtk3/propertypanel.vala	View		10 chunks	+123 lines, -47 lines	4 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

lgtm https://codereview.appspot.com/220500043/diff/1/ui/gtk3/propertypanel.vala File ui/gtk3/propertypanel.vala (right): https://codereview.appspot.com/220500043/diff/1/ui/gtk3/propertypanel.vala#newcode332 ui/gtk3/propertypanel.vala:332: if (desktop == null) does vala support swith ...

9 years, 1 month ago (2015-03-30 16:24:17 UTC) #2

fujiwara

9 years, 1 month ago (2015-03-31 03:06:48 UTC) #3

Message was sent while issue was closed.

Oops, I mistook to run 'git cl push' instead of 'git cl upload'.
But it seems the fixed local patch is integrated in master and no problem.

https://codereview.appspot.com/220500043/diff/1/ui/gtk3/propertypanel.vala
File ui/gtk3/propertypanel.vala (right):

https://codereview.appspot.com/220500043/diff/1/ui/gtk3/propertypanel.vala#ne...
ui/gtk3/propertypanel.vala:332: if (desktop == null)
On 2015/03/30 16:24:16, Peng wrote:
> does vala support swith statement with a string variable?

Done.

https://codereview.appspot.com/220500043/diff/1/ui/gtk3/propertypanel.vala#ne...
ui/gtk3/propertypanel.vala:429: return Gdk.FilterReturn.REMOVE;
On 2015/03/30 16:24:16, Peng wrote:
> Return continue? Maybe gdk will handle thise event as well?

Thanks. I mistook the meaning.
Done.

Expand All Messages | Collapse All Messages