Issue 22049: [jira] Updated: (SHINDIG-955) Add support for experimental view type "x-html-sanitized"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 22049: [jira] Updated: (SHINDIG-955) Add support for experimental view type "x-html-sanitized"

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 11 months ago by louiscryan

Modified:
16 years, 11 months ago

Reviewers:
louiscryan, awiner

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 16 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+74 lines, -21 lines)			Patch
../trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultUrlGenerator.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
../trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizedRenderingContentRewriter.java	View	2 chunks	+3 lines, -1 line	2 comments	Download
../trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsonRpcHandler.java	View	1 chunk	+1 line, -1 line	0 comments	Download
../trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/View.java	View	2 chunks	+28 lines, -9 lines	0 comments	Download
../trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/SanitizedRenderingContentRewriterTest.java	View	2 chunks	+24 lines, -4 lines	0 comments	Download
../trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ViewTest.java	View	2 chunks	+17 lines, -6 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

louiscryan

Key: SHINDIG-955 > URL: https://issues.apache.org/jira/browse/SHINDIG-955 > Project: Shindig > Issue Type: Improvement > Components: Java ...

16 years, 11 months ago (2009-02-27 22:38:35 UTC) #4

awiner

http://codereview.appspot.com/22049/diff/1/4 File ../trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizedRenderingContentRewriter.java (left): http://codereview.appspot.com/22049/diff/1/4#oldcode125 Line 125: if ("1".equals(gadget.getContext().getParameter(ProxyBase.SANITIZE_CONTENT_PARAM))) { RenderingContentRewriter also checks this state. ...

16 years, 11 months ago (2009-02-27 22:42:41 UTC) #5

louiscryan

16 years, 11 months ago (2009-02-27 23:04:54 UTC) #6

http://codereview.appspot.com/22049/diff/1/4
File
../trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizedRenderingContentRewriter.java
(left):

http://codereview.appspot.com/22049/diff/1/4#oldcode125
Line 125: if
("1".equals(gadget.getContext().getParameter(ProxyBase.SANITIZE_CONTENT_PARAM)))
{
On 2009/02/27 22:42:41, awiner wrote:
> RenderingContentRewriter also checks this state.  Maybe extract to a shared
> location?

Done.

Expand All Messages | Collapse All Messages