Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(80)

Issue 22042: Review for Python issue 5094 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by brett.cannon
Modified:
8 years, 11 months ago
Reviewers:
ajaksu
CC:
RafeChops
Base URL:
http://svn.python.org/view/*checkout*/python/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -33 lines) Patch
Doc/includes/tzinfo-examples.py View 1 chunk +0 lines, -16 lines 1 comment Download
Doc/library/datetime.rst View 5 chunks +25 lines, -11 lines 1 comment Download
Include/datetime.h View 2 chunks +6 lines, -0 lines 0 comments Download
Lib/test/test_datetime.py View 5 chunks +21 lines, -1 line 1 comment Download
Modules/datetimemodule.c View 9 chunks +115 lines, -5 lines 5 comments Download

Messages

Total messages: 3
brett.cannon
10 years, 1 month ago (2009-02-27 03:45:09 UTC) #1
brett.cannon
Looks good overall with minor fixes needed, although two things are missing. One, there are ...
10 years, 1 month ago (2009-02-27 04:12:29 UTC) #2
ajaksu
10 years, 1 month ago (2009-02-27 04:38:00 UTC) #3
Two tiny suggestions/questions :)

http://codereview.appspot.com/22042/diff/1/4
File Doc/includes/tzinfo-examples.py (left):

http://codereview.appspot.com/22042/diff/1/4#oldcode6
Line 6: # A UTC class.
I think this bit of unused code did have some educational value... maybe it
could be added to datetime.rst?

http://codereview.appspot.com/22042/diff/1/3
File Doc/library/datetime.rst (left):

http://codereview.appspot.com/22042/diff/1/3#oldcode36
Line 36: application.  The rules for time adjustment across the world are more
political
Maybe a (footnote) mention of/ link to pytz could add value for users reading
this doc?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b