Issue 2204049: Common container: stop using deprecated gadget.rpc.setRelayUrl() and setAuthToken()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2204049: Common container: stop using deprecated gadget.rpc.setRelayUrl() and setAuthToken() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by mhermanto

Modified:
15 years, 4 months ago

Reviewers:
johnfargo

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Patch Set 1 : Update patch. #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
		features/src/main/javascript/features/container/gadget_holder.js	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

johnfargo

LGTM Just a note of caution, I tested this method (which I wrote) a while ...

15 years, 4 months ago (2010-10-19 19:37:45 UTC) #2

mhermanto

Seems to work with Chrome9, IE7, IE8, FF3.6. On 2010/10/19 19:37:45, johnfargo wrote: > LGTM ...

15 years, 4 months ago (2010-10-21 00:32:12 UTC) #3

johnfargo

15 years, 4 months ago (2010-10-22 20:10:36 UTC) #4

LGTM (still)

On Wed, Oct 20, 2010 at 5:32 PM, <mhermanto@gmail.com> wrote:

> Seems to work with Chrome9, IE7, IE8, FF3.6.
>
>
> On 2010/10/19 19:37:45, johnfargo wrote:
>
>> LGTM
>>
>
>  Just a note of caution, I tested this method (which I wrote) a while
>>
> back and it
>
>> worked fine. Even so, it may not be as robust as absolutely needed;
>>
> give it a
>
>> run on a few browsers before committing.
>>
>
>  On 2010/09/25 00:17:16, mhermanto wrote:
>>
>
>
>
> http://codereview.appspot.com/2204049/
>

Expand All Messages | Collapse All Messages